found tox.ini updates, and searched for references of mypy.

Author: pierceroberts

.gitignore

@@ -56,8 +56,6 @@ htmlcov
 # Sphinx
 _build/
 
-# mypy
-.mypy_cache/
 target
 
 # Django example

CONTRIBUTING.md

@@ -60,6 +60,11 @@ You can run `tox` with the following arguments:
 - `tox -e lint-some-package` to run lint checks on `some-package`
 - `tox -e generate-workflows` to run creation of new CI workflows if tox environments have been updated
 - `tox -e ruff` to run ruff linter and formatter checks against the entire codebase
+- `tox -e pyright` to run pyright against entire code base.
+- `tox -e public-symbols-check` to run public_symbols_checker.py.
+- `tox -e docker-tests-{otlpexporter,opencensus}` to run tests in both or either one location.
+- `tox -e tracecontext` to run integration tests for tracecontext.
+- `tox -d sphinx-build` to build html sphinx docs.
 
 `ruff check` and `ruff format` are executed when `tox -e ruff` is run. We strongly recommend you to configure [pre-commit](https://pre-commit.com/) locally to run `ruff` automatically before each commit by installing it as git hooks. You just need to [install pre-commit](https://pre-commit.com/#install) in your environment:
 

opentelemetry-sdk/tests/metrics/test_backward_compat.py

@@ -22,7 +22,7 @@
 and PeriodicExportingMetricReader concrete class. Those may freely be modified in a
 backward-compatible way for *callers*.
 
-Ideally, we could use mypy for this as well, but SDK is not type checked atm.
+Ideally, we could use pyright for this as well, but SDK is not type checked atm.
 """
 
 from typing import Iterable, Sequence

pyproject.toml

@@ -9,13 +9,25 @@ include = [
     "opentelemetry-api/src",
     "opentelemetry-sdk/src",
     "opentelemetry-semantic-conventions/src",
+    "opentelemetry-proto/src",
+    "scripts"
+]
+ignore = [
+  "docs/**",
+  "exporter/**",
+  "propagator/**",
+  "shim/**",
+
 ]
 reportUnnecessaryTypeIgnoreComment = true
-pythonVersion >= "3.9"
+pythonVersion = "3.9"
 reportPrivateUsage = false  # Ignore private attributes added by instrumentation packages.
+reportUnusedFunction = true
+reportUnusedVariable = true
+reportUnusedImport = true
 
 exclude = [
-  "opentelemetry-python/tests/**",
+  "tests/**",
 ]
 
 [tool.ruff]

scripts/proto_codegen.sh

@@ -55,7 +55,7 @@ cd $repo_root/opentelemetry-proto/src
 
 # clean up old generated code
 find opentelemetry/ -regex ".*_pb2.*\.pyi?" -exec rm {} +
-
+# unsure if we need to update this. I could not find the module referenced below in this repo. We would need to change this pyright.
 # generate proto code for all protos
 all_protos=$(find $PROTO_REPO_DIR/ -iname "*.proto")
 python -m grpc_tools.protoc \
@@ -70,7 +70,7 @@ service_protos=$(grep -REl "service \w+ {" $PROTO_REPO_DIR/opentelemetry/)
 python -m grpc_tools.protoc \
     -I $PROTO_REPO_DIR \
     --python_out=. \
-    --mypy_out=. \
+    --mypy_out=. \ 
     --grpc_python_out=. \
     $service_protos
 

tox.ini

@@ -88,7 +88,6 @@ envlist =
 
     spellcheck
     tracecontext
-    mypy,mypyinstalled
     pyright
     docs
     docker-tests-{otlpexporter,opencensus}
@@ -99,7 +98,7 @@ envlist =
 
 [testenv]
 deps =
-  lint: -r dev-requirements.txt
+  lint: -r dev-requirements.txt # I think we should look into using something like pip-sync to keep this env inline with the requirements.txt.
   coverage: pytest
   coverage: pytest-cov
 
@@ -144,7 +143,6 @@ deps =
 
   propagator-jaeger: -r {toxinidir}/propagator/opentelemetry-propagator-jaeger/test-requirements.txt
 
-  mypyinstalled: -e {toxinidir}/opentelemetry-api
 
   getting-started: -r {toxinidir}/docs/getting_started/tests/requirements.txt
   getting-started: {env:CONTRIB_REPO}\#egg=opentelemetry-util-http&subdirectory=util/opentelemetry-util-http
@@ -160,7 +158,6 @@ setenv =
   ; i.e: CONTRIB_REPO_SHA=dde62cebffe519c35875af6d06fae053b3be65ec tox -e <env to test>
   CONTRIB_REPO_SHA={env:CONTRIB_REPO_SHA:main}
   CONTRIB_REPO=git+https://github.com/open-telemetry/opentelemetry-python-contrib.git@{env:CONTRIB_REPO_SHA}
-  mypy: MYPYPATH={toxinidir}/opentelemetry-api/src/:{toxinidir}/opentelemetry-semantic-conventions/src/:{toxinidir}/opentelemetry-sdk/src/:{toxinidir}/tests/opentelemetry-test-utils/src/
 
 commands_pre =
   ; In order to get a healthy coverage report,
@@ -230,19 +227,8 @@ commands =
 
   coverage: {toxinidir}/scripts/coverage.sh
 
-  mypy: mypy --version
-  mypy: mypy --install-types --non-interactive --namespace-packages --explicit-package-bases opentelemetry-api/src/opentelemetry/
-  mypy: mypy --install-types --non-interactive --namespace-packages --explicit-package-bases opentelemetry-sdk/src/opentelemetry/sdk/resources
-  mypy: mypy --install-types --non-interactive --namespace-packages --explicit-package-bases opentelemetry-semantic-conventions/src/opentelemetry/semconv/
-
-; For test code, we don't want to enforce the full mypy strictness
-  mypy: mypy --install-types --non-interactive --namespace-packages --config-file=mypy-relaxed.ini opentelemetry-api/tests/
-
-; Test that mypy can pick up typeinfo from an installed package (otherwise,
-; implicit Any due to unfollowed import would result).
-  mypyinstalled: mypy --install-types --non-interactive --namespace-packages opentelemetry-api/tests/mypysmoke.py --strict
-
-[testenv:spellcheck]
+  
+[testenv:sphinx-build] # there were 2 instances of this name (spellcheck), renaming to sphinx-build
 basepython: python3
 recreate = True
 deps =