Skip to content

suppress unnecesary test messages from logs benchmark #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emdneto wants to merge 2 commits into from
Closed

suppress unnecesary test messages from logs benchmark #4242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aa593fb
suppress unecessary test messages from logs benchmark
emdneto Oct 30, 2024
367c5db
Merge branch 'main' into clean-benchmark-logs
emdneto Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions opentelemetry-sdk/benchmarks/logs/test_benchmark_logging_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ def _create_logger(handler, name):


@pytest.mark.parametrize("num_loggers", [1, 10, 100, 1000])
def test_simple_get_logger_different_names(benchmark, num_loggers):
def test_simple_get_logger_different_names(benchmark, num_loggers, caplog):
handler = _set_up_logging_handler(level=logging.DEBUG)
loggers = [
_create_logger(handler, str(f"logger_{i}")) for i in range(num_loggers)
]

def benchmark_get_logger():
for index in range(1000):
loggers[index % num_loggers].warning("test message")
with caplog.at_level(logging.ERROR):
for index in range(1000):
loggers[index % num_loggers].warning("test message")

benchmark(benchmark_get_logger)