Skip to content

fix: add attributes to get_meter wrapper #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lzchen merged 8 commits into from
Dec 20, 2024
Merged

fix: add attributes to get_meter wrapper #4364

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
63c9ab2
fix: add attributes to get_meter wrapper
Maxi91f Dec 17, 2024
5533b96
changelog and added tests
Maxi91f Dec 18, 2024
304db4c
Merge branch 'main' into fix-get-meter-attributes
Maxi91f Dec 18, 2024
48ea60d
lint fix
Maxi91f Dec 18, 2024
b5008b0
Update CHANGELOG.md
xrmx Dec 19, 2024
d9c26fb
Merge branch 'main' into fix-get-meter-attributes
Maxi91f Dec 19, 2024
e85ded4
Merge branch 'main' into fix-get-meter-attributes
Maxi91f Dec 19, 2024
cb087a2
Merge branch 'main' into fix-get-meter-attributes
lzchen Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion opentelemetry-api/src/opentelemetry/metrics/_internal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,7 @@ def get_meter(
version: str = "",
meter_provider: Optional[MeterProvider] = None,
schema_url: Optional[str] = None,
attributes: Optional[Attributes] = None,
) -> "Meter":
"""Returns a `Meter` for use by the given instrumentation library.

Expand All @@ -774,7 +775,7 @@ def get_meter(
"""
if meter_provider is None:
meter_provider = get_meter_provider()
return meter_provider.get_meter(name, version, schema_url)
return meter_provider.get_meter(name, version, schema_url, attributes)


def _set_meter_provider(meter_provider: MeterProvider, log: bool) -> None:
Expand Down