Skip to content

fix: add missing typing on TracerProvider.shutdown #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xrmx merged 1 commit into from
Dec 19, 2024
Merged

fix: add missing typing on TracerProvider.shutdown #4365

xrmx merged 1 commit into from
Dec 19, 2024

Conversation

@jd
Copy link
Contributor

@jd jd commented Dec 19, 2024 •
edited
Loading

Description

Add missing typing on TracerProvider.shutdown

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@jd jd requested a review from a team as a code owner December 19, 2024 08:27
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 19, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: jd / name: Julien Danjou (8586a32)

@xrmx xrmx enabled auto-merge (squash) December 19, 2024 13:39
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 19, 2024
@xrmx xrmx merged commit b482235 into open-telemetry:main Dec 19, 2024
354 of 355 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

+2 more reviewers

@DouglasBlackwood DouglasBlackwood DouglasBlackwood approved these changes

@Syffe Syffe Syffe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jd @xrmx @DouglasBlackwood @Syffe