Fix for issue #4732 - Invalid type WSGIRequest for attribute 'request' value opentelemetry #4733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y-python into rads-1996/calendar-link-update
rads-1996
force-pushed
the
fix-issue-4732
branch
from
c6779cc to
5c5ac8a
Compare
xrmx
reviewed
Aug 27, 2025
| value = value[:max_len] | ||
| return value | ||
|
|
||
| if _WSGIRequest is not None and isinstance(value, _WSGIRequest): |
Contributor
There was a problem hiding this comment.
I don't think this is the right place to handle this. This function expect value to be of type AnyValue so callers should respect that.
Since you have a reproducer to debug this I'll get a stacktrace (with the traceback module or a debugger) when value is a WSGIRequest and post it on the issue.
Contributor
|
Closing this, I think the proper fix would be a PR in -contrib |
github-project-automation
bot
moved this from Reviewed PR that needs fixing
to Done
in @xrmx's Python PR digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4732
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: