feat: semconv testing

Author: hannahramadan

instrumentation/http/Appraisals

@@ -4,10 +4,19 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-appraise 'http-4.4' do
-  gem 'http', '~> 4.4.0'
-end
+# To faclitate HTTP semantic convention stability migration, we are using
+# appraisal to test the different semantic convention modes along with different
+# HTTP gem versions. For more information on the semantic convention modes, see:
+# https://opentelemetry.io/docs/specs/semconv/non-normative/http-migration/
+
+semconv_stability = %w[dup stable old]
+
+semconv_stability.each do |mode|
+  appraise "http-4.4 #{mode}" do
+    gem 'http', '~> 4.4.0'
+  end
 
-appraise 'http-3.3.0' do
-  gem 'http', '~> 3.3.0'
+  appraise "http-3.3 #{mode}" do
+    gem 'http', '~> 3.3.0'
+  end
 end

instrumentation/http/lib/opentelemetry/instrumentation/http/instrumentation.rb

@@ -64,4 +64,4 @@ def require_dependencies_stable
       end
     end
   end
-end
+end

instrumentation/http/test/instrumentation/http/instrumentation_test.rb

@@ -9,6 +9,8 @@
 require_relative '../../../lib/opentelemetry/instrumentation/http'
 
 describe OpenTelemetry::Instrumentation::HTTP do
+  before { skip unless ENV['BUNDLE_GEMFILE'].include?('old') }
+
   let(:instrumentation) { OpenTelemetry::Instrumentation::HTTP::Instrumentation.instance }
 
   it 'has #name' do

instrumentation/http/test/instrumentation/http/patches/dup/client_test.rb

@@ -20,9 +20,10 @@
   end
   let(:span_name_formatter) { nil }
 
-  ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup'
-
   before do
+    skip unless ENV['BUNDLE_GEMFILE'].include?('dup')
+
+    ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup'
     exporter.reset
     @orig_propagation = OpenTelemetry.propagation
     propagator = OpenTelemetry::Trace::Propagation::TraceContext.text_map_propagator
@@ -37,6 +38,7 @@
   end
 
   after do
+    ENV.delete('OTEL_SEMCONV_STABILITY_OPT_IN')
     # Force re-install of instrumentation
     instrumentation.instance_variable_set(:@installed, false)
     OpenTelemetry.propagation = @orig_propagation
@@ -47,13 +49,15 @@
       HTTP.get('http://example.com/success')
       _(exporter.finished_spans.size).must_equal(1)
       _(span.name).must_equal 'HTTP GET'
+
       # Old semantic conventions
       _(span.attributes['http.method']).must_equal 'GET'
       _(span.attributes['http.scheme']).must_equal 'http'
       _(span.attributes['http.status_code']).must_equal 200
       _(span.attributes['http.target']).must_equal '/success'
       _(span.attributes['net.peer.name']).must_equal 'example.com'
       _(span.attributes['net.peer.port']).must_equal 80
+
       # Stable semantic conventions
       _(span.attributes['http.request.method']).must_equal 'GET'
       _(span.attributes['url.scheme']).must_equal 'http'

instrumentation/http/test/instrumentation/http/patches/dup/connection_test.rb

@@ -15,12 +15,16 @@
   let(:span) { exporter.finished_spans.first }
 
   before do
+    skip unless ENV['BUNDLE_GEMFILE'].include?('dup')
+
+    ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup'
     exporter.reset
     instrumentation.install({})
   end
 
   # Force re-install of instrumentation
   after do
+    ENV.delete('OTEL_SEMCONV_STABILITY_OPT_IN')
     instrumentation.instance_variable_set(:@installed, false)
   end
 
@@ -38,10 +42,12 @@
 
       _(exporter.finished_spans.size).must_equal(2)
       _(span.name).must_equal 'HTTP CONNECT'
+
       # Old semantic conventions
       _(span.attributes['net.peer.name']).must_equal('localhost')
       _(span.attributes['net.peer.port']).wont_be_nil
-      # New semantic conventions
+
+      # Stable semantic conventions
       _(span.attributes['server.address']).must_equal('localhost')
       _(span.attributes['server.port']).wont_be_nil
     ensure

instrumentation/http/test/instrumentation/http/patches/old/client_test.rb

@@ -21,6 +21,8 @@
   let(:span_name_formatter) { nil }
 
   before do
+    skip unless ENV['BUNDLE_GEMFILE'].include?('old')
+
     exporter.reset
     @orig_propagation = OpenTelemetry.propagation
     propagator = OpenTelemetry::Trace::Propagation::TraceContext.text_map_propagator

instrumentation/http/test/instrumentation/http/patches/old/connection_test.rb renamed to instrumentation/http/test/instrumentation/http/patches/old/connection.rb

@@ -15,6 +15,8 @@
   let(:span) { exporter.finished_spans.first }
 
   before do
+    skip unless ENV['BUNDLE_GEMFILE'].include?('old')
+
     exporter.reset
     instrumentation.install({})
   end