Skip to content

Commit 180ec8e

Browse files
committed
fix: resolve merge conflict
2 parents f233fcf + 9e8fe43 commit 180ec8e

File tree

3 files changed

+21
-3
lines changed

3 files changed

+21
-3
lines changed

instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/middlewares/dup/tracer_middleware.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,13 @@ def call(env)
4141
) do |span|
4242
OpenTelemetry.propagation.inject(env.request_headers)
4343

44-
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
44+
if config[:enable_internal_instrumentation] == false
45+
OpenTelemetry::Common::Utilities.untraced do
46+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
47+
end
48+
else
49+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
50+
end
4551
rescue ::Faraday::Error => e
4652
trace_response(span, e.response[:status]) if e.response
4753

instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/middlewares/old/tracer_middleware.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,13 @@ def call(env)
4141
) do |span|
4242
OpenTelemetry.propagation.inject(env.request_headers)
4343

44-
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
44+
if config[:enable_internal_instrumentation] == false
45+
OpenTelemetry::Common::Utilities.untraced do
46+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
47+
end
48+
else
49+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
50+
end
4551
rescue ::Faraday::Error => e
4652
trace_response(span, e.response[:status]) if e.response
4753

instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/middlewares/stable/tracer_middleware.rb

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,13 @@ def call(env)
4141
) do |span|
4242
OpenTelemetry.propagation.inject(env.request_headers)
4343

44-
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
44+
if config[:enable_internal_instrumentation] == false
45+
OpenTelemetry::Common::Utilities.untraced do
46+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
47+
end
48+
else
49+
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
50+
end
4551
rescue ::Faraday::Error => e
4652
trace_response(span, e.response[:status]) if e.response
4753

0 commit comments

Comments
 (0)