fix: skip instrumenting dalli 4.2.0 (#1982)

* fix: skip instrumenting dalli 4.2.0

* rubocop

* use compatible? block

* Restrict gem install and update README

* rubocop: alphabetize dependencies

* Revert dependency changes, use compatiable block

---------

Co-authored-by: Ariel Valentin <arielvalentin@users.noreply.github.com>

Author: hannahramadan

instrumentation/dalli/Appraisals

@@ -1,11 +1,13 @@
 # frozen_string_literal: true
 
-%w[2.7.0 3.2.0].each do |version|
+%w[2.7.0 3.2.0 4.1.0].each do |version|
   appraise "dalli-#{version}" do
     gem 'dalli', "~> #{version}"
   end
 end
 
-appraise 'dalli-latest' do
-  gem 'dalli'
-end
+# Dalli 4.2.0+ has native OpenTelemetry support, so we no longer need
+# to test our instrumentation against it.
+# appraise 'dalli-latest' do
+#   gem 'dalli'
+# end

instrumentation/dalli/README.md

@@ -2,6 +2,15 @@
 
 The OpenTelemetry Dalli gem is a community maintained instrumentation for the [Dalli][dalli-home] Memcache client.
 
+## Dalli 4.2.0+ Native Integration
+
+Dalli 4.2.0+ includes native OpenTelemetry instrumentation. For the best experience and continued support, we recommend:
+
+- **Dalli < 4.2.0**: Use `opentelemetry-instrumentation-dalli` gem
+- **Dalli ≥ 4.2.0**: Use Dalli's built-in OpenTelemetry support (remove `opentelemetry-instrumentation-dalli` gem)
+
+Community instrumentation is compatible with Dalli versions up to 4.1.x. Development of this gem is frozen for newer Dalli versions in favor of the native integration.
+
 ## How do I get started?
 
 Install the gem using:

instrumentation/dalli/lib/opentelemetry/instrumentation/dalli/instrumentation.rb

@@ -10,6 +10,8 @@ module Dalli
       # The Instrumentation class contains logic to detect and install the Dalli
       # instrumentation
       class Instrumentation < OpenTelemetry::Instrumentation::Base
+        MAX_VERSION = Gem::Version.new('4.1.0') # Dalli 4.2.0+ has native OpenTelemetry instrumentation
+
         install do |_config|
           require_dependencies
           add_patches
@@ -19,18 +21,31 @@ class Instrumentation < OpenTelemetry::Instrumentation::Base
           defined?(::Dalli)
         end
 
+        compatible do
+          if gem_version > MAX_VERSION
+            OpenTelemetry.logger.info("Dalli #{gem_version} has native OpenTelemetry support. Skipping community instrumentation.")
+            return false
+          end
+
+          true
+        end
+
         option :peer_service, default: nil, validate: :string
         option :db_statement, default: :obfuscate, validate: %I[omit obfuscate include]
 
         private
 
+        def gem_version
+          Gem::Version.new(::Dalli::VERSION)
+        end
+
         def require_dependencies
           require_relative 'utils'
           require_relative 'patches/server'
         end
 
         def add_patches
-          if Gem::Version.new(::Dalli::VERSION) < Gem::Version.new('3.0.0')
+          if gem_version < Gem::Version.new('3.0.0')
             ::Dalli::Server.prepend(Patches::Server)
           else
             ::Dalli::Protocol::Binary.prepend(Patches::Server) if defined?(::Dalli::Protocol::Binary)