Consolidate rubocop in root of repo (#84)

* consolidate the cops

* bump to 1.3.0

* remove test rubocop files

* update rubocop

* rubocop . -a

* update tests

* commit more fixes

* more cop appeasing

* don't care about ordered gems

* try to ignore vendor bundle

* hail mary

* doh

* fix namespacing

* remove redundant begins

* ignore

* remove templates from instrumentation generator

* Revert "remove templates from instrumentation generator"

This reverts commit 9ba82e0.

* update rubocop.yml template; don't add rubocop file to test/

* prefer inline rubocop:disable to root .rubocop.yml file

* ignore ascii comment violation

Co-authored-by: Ariel Valentin <[email protected]>

Author: plantfansam

.instrumentation_generator/instrumentation_generator.rb

@@ -35,7 +35,6 @@ def lib_files
   end
 
   def test_files
-    template('templates/test/.rubocop.yml', "#{instrumentation_path}/test/.rubocop.yml")
     template('templates/test/test_helper.rb', "#{instrumentation_path}/test/test_helper.rb")
     template('templates/test/instrumentation.rb', "#{instrumentation_path}/test/opentelemetry/#{instrumentation_path}/instrumentation_test.rb")
   end

.instrumentation_generator/templates/gemspec.tt

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'opentelemetry-sdk', '~> 1.0'
   spec.add_development_dependency 'opentelemetry-test-helpers'
   spec.add_development_dependency 'rake', '~> 12.3.3'
-  spec.add_development_dependency 'rubocop', '~> 0.73.0'
+  spec.add_development_dependency 'rubocop', '~> 1.3.0'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
   spec.add_development_dependency 'webmock', '~> 3.7.6'
   spec.add_development_dependency 'yard', '~> 0.9'

.instrumentation_generator/templates/rubocop.yml.tt

@@ -1,5 +1 @@
-inherit_from: ../.rubocop-examples.yml
-
-Naming/FileName:
-  Exclude:
-    - "lib/opentelemetry-instrumentation-<%= instrumentation_name %>.rb"
+inherit_from: ../../.rubocop.yml

.instrumentation_generator/templates/test/.rubocop.yml

@@ -0,0 +1,52 @@
+AllCops:
+  TargetRubyVersion: '2.7.6'
+  Exclude:
+    - Rakefile
+    - "rakelib/**/*"
+    - "**/example/*"
+    - "bin/instrumentation_generator"
+    - "**/**/vendor/bundle/**/*"
+Bundler/OrderedGems:
+  Enabled: false
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/MethodLength:
+  Max: 20
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - "**/*test.rb"
+Lint/UnusedMethodArgument:
+  Enabled: false
+Naming/FileName:
+  Exclude:
+    - '**/opentelemetry-*'
+Metrics/LineLength:
+  Enabled: false
+Metrics/ParameterLists:
+  Enabled: false
+Style/Documentation:
+  Exclude:
+    - "**/test/**/*"
+    - "**/*test*"
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - "**/gemfiles/*"
+Style/ModuleFunction:
+  Enabled: false
+Style/MultilineIfModifier:
+  Exclude:
+     - "**/test/**/*"
+Style/RedundantRegexpEscape:
+  Enabled: false
+Style/StringLiterals:
+  Exclude:
+    - "**/gemfiles/*"
+Style/SlicingWithRange:
+  Enabled: false
+Style/CaseLikeIf:
+  Enabled: false
+

.rubocop.yml

@@ -1,5 +1 @@
-inherit_from: ../.rubocop-examples.yml
-
-Naming/FileName:
-  Exclude:
-    - "lib/opentelemetry-instrumentation-action_pack.rb"
+inherit_from: ../../.rubocop.yml

instrumentation/action_pack/.rubocop.yml

@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'opentelemetry-test-helpers'
   spec.add_development_dependency 'rails'
   spec.add_development_dependency 'rake', '~> 12.3.3'
-  spec.add_development_dependency 'rubocop', '~> 0.73.0'
+  spec.add_development_dependency 'rubocop', '~> 1.3.0'
   spec.add_development_dependency 'simplecov', '~> 0.17.1'
   spec.add_development_dependency 'webmock', '~> 3.7.6'
   spec.add_development_dependency 'yard', '~> 0.9'

instrumentation/action_pack/opentelemetry-instrumentation-action_pack.gemspec

@@ -13,7 +13,7 @@
 require 'minitest/autorun'
 require 'rack/test'
 
-require 'test_helpers/app_config.rb'
+require 'test_helpers/app_config'
 require_relative '../lib/opentelemetry/instrumentation'
 
 # Global opentelemetry-sdk setup

instrumentation/action_pack/test/.rubocop.yml

@@ -1,5 +1 @@
-inherit_from: ../.rubocop-examples.yml
-
-Naming/FileName:
-  Exclude:
-    - "lib/opentelemetry-instrumentation-action_view.rb"
+inherit_from: ../../.rubocop.yml