squash: preserve broken ethon gem

Author: arielvalentin

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/http_helper.rb

@@ -74,7 +74,7 @@ def self.span_attrs_for(method, semconv: :stable)
             )
           else
             SpanCreationAttributes.new(
-              span_name: 'HTTP',
+              span_name: semconv == :old ? 'HTTP N/A' : 'HTTP',
               normalized_method: '_OTHER',
               original_method: method.to_s
             )

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/old/instrumentation_test.rb

@@ -69,7 +69,7 @@
             easy.stub(:complete, nil) do
               easy.perform
 
-              _(span.name).must_equal 'HTTP'
+              _(span.name).must_equal 'HTTP N/A'
               _(span.attributes['http.method']).must_equal '_OTHER'
               _(span.attributes['http.status_code']).must_be_nil
               _(span.attributes['http.url']).must_equal 'http://example.com/test'
@@ -87,7 +87,7 @@
 
               # NOTE: check the finished spans since we expect to have closed it
               span = exporter.finished_spans.first
-              _(span.name).must_equal 'HTTP'
+              _(span.name).must_equal 'HTTP N/A'
               _(span.attributes['http.method']).must_equal '_OTHER'
               _(span.attributes['http.status_code']).must_be_nil
               _(span.attributes['http.url']).must_equal 'http://example.com/test'
@@ -113,7 +113,7 @@ def stub_response(options)
 
         it 'when response is successful' do
           stub_response(response_code: 200) do
-            _(span.name).must_equal 'HTTP'
+            _(span.name).must_equal 'HTTP N/A'
             _(span.attributes['http.method']).must_equal '_OTHER'
             _(span.attributes['http.status_code']).must_equal 200
             _(span.attributes['http.url']).must_equal 'http://example.com/test'
@@ -126,7 +126,7 @@ def stub_response(options)
 
         it 'when response is not successful' do
           stub_response(response_code: 500) do
-            _(span.name).must_equal 'HTTP'
+            _(span.name).must_equal 'HTTP N/A'
             _(span.attributes['http.method']).must_equal '_OTHER'
             _(span.attributes['http.status_code']).must_equal 500
             _(span.attributes['http.url']).must_equal 'http://example.com/test'
@@ -139,9 +139,9 @@ def stub_response(options)
 
         it 'when request times out' do
           stub_response(response_code: 0, return_code: :operation_timedout) do
-            _(span.name).must_equal 'HTTP'
+            _(span.name).must_equal 'HTTP N/A'
             _(span.attributes['http.method']).must_equal '_OTHER'
-            _(span.attributes['http.status_code']).must_be_nil
+            _(span.attributes['http.status_code']).must_equal 0
             _(span.attributes['http.url']).must_equal 'http://example.com/test'
             _(span.status.code).must_equal(
               OpenTelemetry::Trace::Status::ERROR
@@ -255,7 +255,7 @@ def stub_response(options)
 
           stub_response(response_code: 200) do
             _(exporter.finished_spans.size).must_equal 1
-            _(span.name).must_equal 'HTTP'
+            _(span.name).must_equal 'HTTP N/A'
             _(span.attributes['http.method']).must_equal '_OTHER'
             _(span.attributes['http.url']).must_equal 'http://example.com/purge'
           end