use the proper timestamps in the client too

Author: dmathieu

instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/middlewares/client/tracer_middleware.rb

@@ -31,7 +31,7 @@ def call(_worker_class, job, _queue, _redis_pool)
 
               tracer.in_span(span_name, attributes: attributes, kind: :producer) do |span|
                 OpenTelemetry.propagation.inject(job)
-                span.add_event('created_at', timestamp: job['created_at'])
+                span.add_event('created_at', timestamp: time_from_timestamp(job['created_at']))
                 yield
               end
             end
@@ -45,6 +45,15 @@ def instrumentation_config
             def tracer
               Sidekiq::Instrumentation.instance.tracer
             end
+
+            def time_from_timestamp(timestamp)
+              if timestamp.is_a?(Float)
+                # old format, timestamps were stored as fractional seconds since the epoch
+                timestamp
+              else
+                timestamp / 1000
+              end
+            end
           end
         end
       end

instrumentation/sidekiq/test/opentelemetry/instrumentation/sidekiq/middlewares/client/tracer_middleware_test.rb

@@ -44,7 +44,10 @@
       _(enqueue_span.attributes['messaging.destination']).must_equal 'default'
       _(enqueue_span.attributes['messaging.destination_kind']).must_equal 'queue'
       _(enqueue_span.events.size).must_equal(1)
-      _(enqueue_span.events[0].name).must_equal('created_at')
+
+      created_event = enqueue_span.events[0]
+      _(created_event.name).must_equal('created_at')
+      _(created_event.timestamp.digits.count).must_equal(19)
     end
 
     it 'traces when enqueued with Active Job' do