Skip to content

Commit 48077e3

Browse files
committed
fix: loosen version constraints to support old versions
1 parent 558d40d commit 48077e3

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Rdkafka
1111
class Instrumentation < OpenTelemetry::Instrumentation::Base
1212
compatible do
1313
gem_version = Gem::Version.new(::Rdkafka::VERSION)
14-
Gem::Requirement.new('>= 0.20.0').satisfied_by?(gem_version)
14+
Gem::Requirement.new('>= 0.10.0').satisfied_by?(gem_version)
1515
end
1616

1717
install do |_config|

instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/patches/consumer.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def each
4242
end
4343
end
4444

45-
# each_batch method is deleted in rdkafka 0.20.0
45+
# each_batch method is deleted in rdkafka-ruby-0.20.0
46+
# But, rdkafka-ruby-0.19.x and 0.18.x are still maintained
4647
if Gem::Version.new(::Rdkafka::VERSION) < Gem::Version.new('0.20.0')
4748
def each_batch(max_items: 100, bytes_threshold: Float::INFINITY, timeout_ms: 250, yield_on_error: false, &block)
4849
super do |messages, error|

0 commit comments

Comments
 (0)