Skip to content

Commit 5644ee5

Browse files
authored
Merge branch 'main' into ams-set-current-span-during-serialization-event
2 parents 13f2b7f + 3584cfa commit 5644ee5

File tree

146 files changed

+627
-273
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

146 files changed

+627
-273
lines changed

.github/actions/test_gem/action.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,13 @@ runs:
8282
ruby-version: "${{ inputs.ruby }}"
8383
bundler: "latest"
8484
working-directory: "${{ steps.setup.outputs.gem_dir }}"
85+
# Perms workaround. See https://github.com/actions/runner-images/issues/10215
86+
- name: Fix GEM_HOME permissions on GitHub Actions Runner
87+
if: "${{ steps.setup.outputs.appraisals == 'true' }}"
88+
shell: bash
89+
run: |
90+
# 🛠️😭 Fix GEM_HOME permissions 😭🛠️
91+
chmod -R o-w $(gem env home)
8592
- name: Install dependencies and generate appraisals
8693
if: "${{ steps.setup.outputs.appraisals == 'true' }}"
8794
shell: bash
@@ -100,7 +107,7 @@ runs:
100107
echo "::group::🔎 Appraising ${i}"
101108
BUNDLE_GEMFILE=gemfiles/${i}.gemfile bundle install --quiet --jobs=3 --retry=4 && \
102109
BUNDLE_GEMFILE=gemfiles/${i}.gemfile bundle show && \
103-
BUNDLE_GEMFILE=gemfiles/${i}.gemfile bundle exec rake test
110+
BUNDLE_GEMFILE=gemfiles/${i}.gemfile bundle exec rake test || exit
104111
echo "::endgroup::"
105112
done
106113
else

.github/workflows/ci-contrib.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ jobs:
2929
runs-on: ${{ matrix.os }}
3030
steps:
3131
- uses: actions/checkout@v4
32+
- name: "Test Ruby 3.3"
33+
uses: ./.github/actions/test_gem
34+
with:
35+
gem: "opentelemetry-helpers-${{ matrix.gem }}"
36+
ruby: "3.3"
3237
- name: "Test Ruby 3.2"
3338
uses: ./.github/actions/test_gem
3439
with:
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Markdown Link Check
2+
3+
on:
4+
pull_request:
5+
6+
jobs:
7+
markdown-link-check:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v4
11+
12+
- name: "Markdown Link Check"
13+
uses: gaurav-nelson/github-action-markdown-link-check@v1
14+
with:
15+
config-file: '.markdown-link-check.json'
16+
use-quiet-mode: 'yes'
17+
use-verbose-mode: 'yes'
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
name: Markdown Lint Check
2+
3+
on:
4+
pull_request:
5+
6+
jobs:
7+
markdownlint-check:
8+
runs-on: ubuntu-latest
9+
steps:
10+
- uses: actions/checkout@v4
11+
12+
# equivalent cli: markdownlint-cli2 "**/*.md" "#**/CHANGELOG.md" --config .markdownlint.json
13+
- name: "Markdown Lint Check"
14+
uses: DavidAnson/markdownlint-cli2-action@v16
15+
with:
16+
fix: false
17+
globs: |
18+
**/*.md
19+
!**/CHANGELOG.md
20+
continue-on-error: true

.instrumentation_generator/templates/Readme.md.tt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Todo: Add a description.
66

77
Install the gem using:
88

9-
```
9+
```console
1010
gem install opentelemetry-instrumentation-<%= instrumentation_name %>
1111
```
1212

@@ -38,7 +38,7 @@ Example usage can be seen in the `./example/trace_demonstration.rb` file [here](
3838

3939
The `opentelemetry-instrumentation-<%= instrumentation_name %>` gem source is [on github][repo-github], along with related gems including `opentelemetry-api` and `opentelemetry-sdk`.
4040

41-
The OpenTelemetry Ruby gems are maintained by the OpenTelemetry-Ruby special interest group (SIG). You can get involved by joining us in [GitHub Discussions][discussions-url] or attending our weekly meeting. See the [meeting calendar][community-meetings] for dates and times. For more information on this and other language SIGs, see the OpenTelemetry [community page][ruby-sig].
41+
The OpenTelemetry Ruby gems are maintained by the OpenTelemetry Ruby special interest group (SIG). You can get involved by joining us on our [GitHub Discussions][discussions-url], [Slack Channel][slack-channel] or attending our weekly meeting. See the [meeting calendar][community-meetings] for dates and times. For more information on this and other language SIGs, see the OpenTelemetry [community page][ruby-sig].
4242

4343
## License
4444

@@ -49,4 +49,5 @@ The `opentelemetry-instrumentation-<%= instrumentation_name %>` gem is distribut
4949
[license-github]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/LICENSE
5050
[ruby-sig]: https://github.com/open-telemetry/community#ruby-sig
5151
[community-meetings]: https://github.com/open-telemetry/community#community-meetings
52+
[slack-channel]: https://cloud-native.slack.com/archives/C01NWKKMKMY
5253
[discussions-url]: https://github.com/open-telemetry/opentelemetry-ruby/discussions

.markdown-link-check.json

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
{
2+
"ignorePatterns": [
3+
{
4+
"pattern": "^http://localhost"
5+
}
6+
],
7+
"timeout": "5s",
8+
"retryOn429": true,
9+
"aliveStatusCodes": [200, 206, 429]
10+
}

.markdownlint.json

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"emphasis-style": false,
3+
"line-length": false,
4+
"link-fragments": false,
5+
"list-marker-space": false,
6+
"no-emphasis-as-heading": false,
7+
"no-hard-tabs": false,
8+
"no-inline-html": false,
9+
"no-trailing-punctuation": false,
10+
"no-trailing-spaces": true,
11+
"custom-rules-below-this-point": false,
12+
"trim-code-block-and-unindent": true
13+
}

CONTRIBUTING.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ bundle exec rake yard
168168

169169
## Instrumentation author's guide
170170

171-
Please make sure that you review the [Instrumentation author's guide](.instrumentation/CONTRIBUTING.md) before submitting a new instrumentation.
171+
Please make sure that you review the [Instrumentation author's guide](instrumentation/CONTRIBUTING.md) before submitting a new instrumentation.
172172

173173
## Create a pull request
174174

@@ -209,10 +209,11 @@ make the project that much better. Respond to the feedback and work with your
209209
reviewer(s) to resolve any issues.
210210

211211
The some of the things the code owners are looking for include:
212+
212213
* a signed [CNCF CLA][cncf-cla]
213214
* a passing CI build
214215
* adherence to the principles and features outlined in the
215-
[instrumentation author's guide](.instrumentation/CONTRIBUTING.md)
216+
[instrumentation author's guide](instrumentation/CONTRIBUTING.md)
216217

217218
Reviewers are responsible for ensuring that each merged PR's commit message
218219
conforms to [conventional commits](https://conventionalcommits.org). This may
@@ -414,7 +415,7 @@ index e29acbfc..85622d25 100644
414415
[cncf-cla]: https://identity.linuxfoundation.org/projects/cncf
415416
[github-draft]: https://github.blog/2019-02-14-introducing-draft-pull-requests/
416417
[kube-github-workflow-pr]: https://github.com/kubernetes/community/blob/master/contributors/guide/github-workflow.md#7-create-a-pull-request
417-
[otel-contributor-guide]: https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md
418-
[otel-github-workflow]: https://github.com/open-telemetry/community/blob/master/CONTRIBUTING.md#github-workflow
418+
[otel-contributor-guide]: https://github.com/open-telemetry/community/blob/main/guides/contributor/README.md
419+
[otel-github-workflow]: https://github.com/open-telemetry/community/blob/main/guides/contributor/processes.md#workflows
419420
[otel-lib-guidelines]: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/library-guidelines.md
420421
[otel-specification]: https://github.com/open-telemetry/opentelemetry-specification

README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Approvers ([@open-telemetry/ruby-contrib-approvers](https://github.com/orgs/open
3030
- [Josef Šimánek](https://github.com/simi)
3131
- [Xuan Cao](https://github.com/xuan-cao-swi), Solarwinds
3232

33-
*Find more about the approver role in [community repository](https://github.com/open-telemetry/community/blob/master/community-membership.md#approver).*
33+
*Find more about the approver role in [community repository](https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#approver).*
3434

3535
Maintainers ([@open-telemetry/ruby-contrib-maintainers](https://github.com/orgs/open-telemetry/teams/ruby-contrib-maintainers)):
3636

@@ -44,7 +44,7 @@ Maintainers ([@open-telemetry/ruby-contrib-maintainers](https://github.com/orgs/
4444
- [Robert Laurin](https://github.com/robertlaurin), Shopify
4545
- [Sam Handler](https://github.com/plantfansam), Shopify
4646

47-
*Find more about the maintainer role in [community repository](https://github.com/open-telemetry/community/blob/master/community-membership.md#maintainer).*
47+
*Find more about the maintainer role in [community repository](https://github.com/open-telemetry/community/blob/main/guides/contributor/membership.md#maintainer).*
4848

4949
## Instrumentation Libraries
5050

@@ -60,6 +60,7 @@ multiple instrumentation libraries.
6060

6161
- [MySQL](helpers/mysql/)
6262
- [SQL Obfuscation](helpers/sql-obfuscation/)
63+
6364
## Additional Libraries
6465

6566
This repository also contains libraries to aid with interoperability with vendor specific tracing solutions:
@@ -103,17 +104,14 @@ Apache 2.0 - See [LICENSE][license-url] for more information.
103104
[otel-ruby]: https://github.com/open-telemetry/opentelemetry-ruby
104105
[otel-ruby-releases]: https://github.com/open-telemetry/opentelemetry-ruby/releases
105106
[otel-ruby-contrib-releases]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/releases
106-
[ci-image]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/workflows/CI/badge.svg?event=push
107-
[examples-github]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/examples
107+
[ci-image]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/workflows/CI%20Contrib/badge.svg?event=push
108108
[getting-started]: https://opentelemetry.io/docs/languages/ruby/getting-started/
109109
[issues-good-first-issue]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
110110
[issues-help-wanted]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22
111111
[license-image]: https://img.shields.io/badge/license-Apache_2.0-green.svg?style=flat
112112
[license-url]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/LICENSE
113113
[ruby-sig]: https://github.com/open-telemetry/community#ruby-sig
114-
[opentelemetry-instrumentation-all-publishing]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/all#publishing
115114
[slack-image]: https://img.shields.io/badge/slack-@cncf/otel/ruby-brightgreen.svg?logo=slack
116115
[slack-url]: https://cloud-native.slack.com/archives/C01NWKKMKMY
117116
[discussions-url]: https://github.com/open-telemetry/opentelemetry-ruby/discussions
118117
[otel-versioning]: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/versioning-and-stability.md
119-
[otel-specification]: https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification

helpers/mysql/README.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ end
2222
```
2323

2424
Make sure the `Instrumentation` class for your gem contains configuration options for:
25+
2526
- `:span_name`: The type of span name desired for the trace.
2627
Example: `option :span_name, default: :statement_type, validate: %I[statement_type db_name db_operation_and_name]`
2728

@@ -43,7 +44,7 @@ end
4344

4445
The `opentelemetry-helpers-mysql` gem source is [on github][repo-github], along with related gems including `opentelemetry-instrumentation-mysql2` and `opentelemetry-instrumentation-trilogy`.
4546

46-
The OpenTelemetry Ruby gems are maintained by the OpenTelemetry-Ruby special interest group (SIG). You can get involved by joining us on our [gitter channel][ruby-gitter] or attending our weekly meeting. See the [meeting calendar][community-meetings] for dates and times. For more information on this and other language SIGs, see the OpenTelemetry [community page][ruby-sig].
47+
The OpenTelemetry Ruby gems are maintained by the OpenTelemetry Ruby special interest group (SIG). You can get involved by joining us on our [GitHub Discussions][discussions-url], [Slack Channel][slack-channel] or attending our weekly meeting. See the [meeting calendar][community-meetings] for dates and times. For more information on this and other language SIGs, see the OpenTelemetry [community page][ruby-sig].
4748

4849
## License
4950

@@ -53,4 +54,5 @@ The `opentelemetry-helpers-mysql` gem is distributed under the Apache 2.0 licens
5354
[license-github]: https://github.com/open-telemetry/opentelemetry-ruby-contrib/blob/main/LICENSE
5455
[ruby-sig]: https://github.com/open-telemetry/community#ruby-sig
5556
[community-meetings]: https://github.com/open-telemetry/community#community-meetings
56-
[ruby-gitter]: https://gitter.im/open-telemetry/opentelemetry-ruby
57+
[slack-channel]: https://cloud-native.slack.com/archives/C01NWKKMKMY
58+
[discussions-url]: https://github.com/open-telemetry/opentelemetry-ruby/discussions

0 commit comments

Comments
 (0)