squash: remove redundant tests

Author: arielvalentin

instrumentation/action_pack/README.md

@@ -48,8 +48,6 @@ This instrumentation generally uses [HTTP server semantic conventions](https://o
 
 For Rails 7.1+, the span name is updated to match the HTTP method and route that was matched for the request using [`ActionDispatch::Request#route_uri_pattern`](https://api.rubyonrails.org/classes/ActionDispatch/Request.html#method-i-route_uri_pattern), e.g.: `GET /users/:id`
 
-For older versions of Rails the span name is updated to match the HTTP method, controller, and action name that was the target of the request, e.g.: `GET /example/index`
-
 > ![NOTE]: Users may override the `span_naming` option to default to Legacy Span Naming Behavior that uses the controller's class name and action in Ruby documentation syntax, e.g. `ExampleController#index`.
 
 This instrumentation does not emit any custom attributes.
@@ -58,7 +56,7 @@ This instrumentation does not emit any custom attributes.
 | - | - | - |
 | `code.namespace` | String | `ActionController` class name |
 | `code.function` | String | `ActionController` action name e.g. `index`, `show`, `edit`, etc... |
-| `http.route` | String | (Rails 7.1+) the route that was matched for the request |
+| `http.route` | String | The route that was matched for the request |
 | `http.target` | String | The `request.filtered_path` |
 
 ### Error Handling for Action Controller

instrumentation/action_pack/test/opentelemetry/instrumentation/action_pack/handlers/action_controller_test.rb

@@ -59,8 +59,6 @@
   end
 
   it 'strips (:format) from http.route' do
-    skip "Rails #{Rails.gem_version} does not define ActionDispatch::Request#route_uri_pattern" if Rails.gem_version < Gem::Version.new('7.1')
-
     get 'items/1234'
 
     _(span.attributes['http.route']).must_equal '/items/:id'
@@ -150,51 +148,21 @@
   describe 'span naming' do
     describe 'when using the default span_naming configuration' do
       describe 'successful requests' do
-        describe 'Rails Version < 7.1' do
-          it 'uses the http method controller and action name' do
-            skip "Rails #{Rails.gem_version} uses ActionDispatch::Request#route_uri_pattern" if Rails.gem_version >= Gem::Version.new('7.1')
-            get '/ok'
-
-            _(span.name).must_equal 'GET /example/ok'
-          end
-
-          it 'excludes route params' do
-            skip "Rails #{Rails.gem_version} uses ActionDispatch::Request#route_uri_pattern" if Rails.gem_version >= Gem::Version.new('7.1')
-            get '/items/1234'
+        it 'uses the Rails route' do
+          get '/ok'
 
-            _(span.name).must_equal 'GET /example/item'
-          end
+          _(span.name).must_equal 'GET /ok'
         end
 
-        describe 'Rails Version >= 7.1' do
-          it 'uses the Rails route' do
-            skip "Rails #{Rails.gem_version} does not define ActionDispatch::Request#route_uri_pattern" if Rails.gem_version < Gem::Version.new('7.1')
-            get '/ok'
+        it 'includes route params' do
+          get '/items/1234'
 
-            _(span.name).must_equal 'GET /ok'
-          end
-
-          it 'includes route params' do
-            skip "Rails #{Rails.gem_version} does not define ActionDispatch::Request#route_uri_pattern" if Rails.gem_version < Gem::Version.new('7.1')
-            get '/items/1234'
-
-            _(span.name).must_equal 'GET /items/:id'
-          end
+          _(span.name).must_equal 'GET /items/:id'
         end
       end
 
       describe 'server errors' do
-        it 'uses the http method controller and action name for server side errors' do
-          skip "Rails #{Rails.gem_version} uses ActionDispatch::Request#route_uri_pattern" if Rails.gem_version >= Gem::Version.new('7.1')
-
-          get 'internal_server_error'
-
-          _(span.name).must_equal 'GET /example/internal_server_error'
-        end
-
         it 'uses the Rails route for server side errors' do
-          skip "Rails #{Rails.gem_version} uses ActionDispatch::Request#route_uri_pattern" if Rails.gem_version < Gem::Version.new('7.1')
-
           get 'internal_server_error'
 
           _(span.name).must_equal 'GET /internal_server_error'