Skip to content

Commit 76bc2bc

Browse files
committed
Fix: refactor duplicate method call
1 parent 26b276e commit 76bc2bc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

instrumentation/excon/lib/opentelemetry/instrumentation/excon/middlewares/dup/tracer_middleware.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,19 @@ def request_call(datum)
2929
return @stack.request_call(datum) if untraced?(datum)
3030

3131
http_method = HTTP_METHODS_TO_UPPERCASE[datum[:method]]
32+
cleansed_url = OpenTelemetry::Common::Utilities.cleanse_url(::Excon::Utils.request_uri(datum))
3233
attributes = {
3334
OpenTelemetry::SemanticConventions::Trace::HTTP_HOST => datum[:host],
3435
OpenTelemetry::SemanticConventions::Trace::HTTP_METHOD => http_method,
3536
OpenTelemetry::SemanticConventions::Trace::HTTP_SCHEME => datum[:scheme],
3637
OpenTelemetry::SemanticConventions::Trace::HTTP_TARGET => datum[:path],
37-
OpenTelemetry::SemanticConventions::Trace::HTTP_URL => OpenTelemetry::Common::Utilities.cleanse_url(::Excon::Utils.request_uri(datum)),
38+
OpenTelemetry::SemanticConventions::Trace::HTTP_URL => cleansed_url,
3839
OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME => datum[:hostname],
3940
OpenTelemetry::SemanticConventions::Trace::NET_PEER_PORT => datum[:port],
4041
'http.request.method' => http_method,
4142
'url.scheme' => datum[:scheme],
4243
'url.path' => datum[:path],
43-
'url.full' => OpenTelemetry::Common::Utilities.cleanse_url(::Excon::Utils.request_uri(datum)),
44+
'url.full' => cleansed_url,
4445
'server.address' => datum[:hostname],
4546
'server.port' => datum[:port]
4647
}

0 commit comments

Comments
 (0)