Skip to content

Commit 8033ffb

Browse files
committed
add better test case
1 parent 67bc53c commit 8033ffb

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

instrumentation/aws_lambda/test/opentelemetry/instrumentation_test.rb

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -217,18 +217,21 @@
217217
end
218218

219219
describe 'no raise error when the span is not recording' do
220-
it 'no raise error xuan' do
221-
original_sampler = OpenTelemetry.tracer_provider.sampler
222-
OpenTelemetry.tracer_provider.sampler = OpenTelemetry::SDK::Trace::Samplers.parent_based(
223-
root: OpenTelemetry::SDK::Trace::Samplers::ALWAYS_OFF
224-
)
225-
220+
it 'no raise error' do
226221
otel_wrapper = OpenTelemetry::Instrumentation::AwsLambda::Handler.new
227-
otel_wrapper.stub(:call_original_handler, {}) do
228-
assert otel_wrapper.call_wrapped(event: sqs_record, context: context) # assert no error will occur if span is not recording
229-
end
222+
tracer = OpenTelemetry.tracer_provider.tracer
230223

231-
OpenTelemetry.tracer_provider.sampler = original_sampler
224+
OpenTelemetry::Trace.stub(:with_span, lambda { |_span, &block|
225+
block.call(OpenTelemetry::Trace::Span::INVALID, OpenTelemetry::Context.current)
226+
}) do
227+
tracer.stub(:in_span, lambda { |_name, **_kwargs, &block|
228+
block.call(OpenTelemetry::Trace::Span::INVALID, OpenTelemetry::Context.current)
229+
}) do
230+
otel_wrapper.stub(:call_original_handler, {}) do
231+
assert otel_wrapper.call_wrapped(event: sqs_record, context: context)
232+
end
233+
end
234+
end
232235
end
233236
end
234237
end

0 commit comments

Comments
 (0)