Skip to content

Commit 8f0e435

Browse files
committed
feat: Bump minimum API Version to 1.7
The instrumentation base gem already has a dependency on the API, so declaring the dependency again isn't necessary. Removing the extra declaration in individual instrumentation gemspecs removes the need to keep all instrumentation gems in sync with each other.
1 parent 760acc2 commit 8f0e435

File tree

55 files changed

+6
-63
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+6
-63
lines changed

.instrumentation_generator/templates/gemspec.tt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> <%= opentelemetry_version %>'
2928
spec.add_dependency 'opentelemetry-instrumentation-base', '~> <%= instrumentation_base_version %>'
3029

3130
if spec.respond_to?(:metadata)

helpers/mysql/opentelemetry-helpers-mysql.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
28+
spec.add_dependency 'opentelemetry-api', '~> 1.7'
2929
spec.add_dependency 'opentelemetry-common', '~> 0.21'
3030

3131
if spec.respond_to?(:metadata)

helpers/sql/opentelemetry-helpers-sql.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
28+
spec.add_dependency 'opentelemetry-api', '~> 1.7'
2929

3030
if spec.respond_to?(:metadata)
3131
spec.metadata['changelog_uri'] = "https://rubydoc.info/gems/#{spec.name}/#{spec.version}/file/CHANGELOG.md"

instrumentation/action_mailer/opentelemetry-instrumentation-action_mailer.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-active_support', '~> 0.7'
30-
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3129

3230
if spec.respond_to?(:metadata)
3331
spec.metadata['changelog_uri'] = "https://rubydoc.info/gems/#{spec.name}/#{spec.version}/file/CHANGELOG.md"

instrumentation/action_pack/opentelemetry-instrumentation-action_pack.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
29-
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3028
spec.add_dependency 'opentelemetry-instrumentation-rack', '~> 0.21'
3129

3230
if spec.respond_to?(:metadata)

instrumentation/action_view/opentelemetry-instrumentation-action_view.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-active_support', '~> 0.7'
30-
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3129

3230
if spec.respond_to?(:metadata)
3331
spec.metadata['changelog_uri'] = "https://rubydoc.info/gems/#{spec.name}/#{spec.version}/file/CHANGELOG.md"

instrumentation/active_job/opentelemetry-instrumentation-active_job.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3029

3130
if spec.respond_to?(:metadata)

instrumentation/active_model_serializers/opentelemetry-instrumentation-active_model_serializers.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-active_support', '>= 0.7.0'
30-
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3129

3230
if spec.respond_to?(:metadata)
3331
spec.metadata['changelog_uri'] = "https://rubydoc.info/gems/#{spec.name}/#{spec.version}/file/CHANGELOG.md"

instrumentation/active_record/opentelemetry-instrumentation-active_record.gemspec

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3029

3130
if spec.respond_to?(:metadata)

instrumentation/active_storage/opentelemetry-instrumentation-active_storage.gemspec

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,7 @@ Gem::Specification.new do |spec|
2525
spec.require_paths = ['lib']
2626
spec.required_ruby_version = ">= #{File.read(File.expand_path('../../gemspecs/RUBY_REQUIREMENT', __dir__))}"
2727

28-
spec.add_dependency 'opentelemetry-api', '~> 1.0'
2928
spec.add_dependency 'opentelemetry-instrumentation-active_support', '~> 0.7'
30-
spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.23'
3129

3230
if spec.respond_to?(:metadata)
3331
spec.metadata['changelog_uri'] = "https://rubydoc.info/gems/#{spec.name}/#{spec.version}/file/CHANGELOG.md"

0 commit comments

Comments
 (0)