Skip to content

Commit 932c70e

Browse files
committed
update logging for utils
1 parent efca3dd commit 932c70e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

sampler/xray/lib/opentelemetry/sampler/xray/sampling_rule_applier.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ module XRay
1818
class SamplingRuleApplier
1919
attr_reader :sampling_rule
2020

21-
# Constants would typically be defined in a separate configuration or constants file
2221
MAX_DATE_TIME_SECONDS = Time.at(8_640_000_000_000)
2322

2423
def initialize(sampling_rule, statistics = OpenTelemetry::Sampler::XRay::Statistics.new, target = nil)

sampler/xray/lib/opentelemetry/sampler/xray/utils.rb

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ module XRay
1111
module Utils
1212
module_function
1313

14-
# NOTE: These constants would typically come from a Ruby gem equivalent to @opentelemetry/semantic-conventions
1514
CLOUD_PLATFORM_MAPPING = {
1615
'aws_lambda' => 'AWS::Lambda::Function',
1716
'aws_elastic_beanstalk' => 'AWS::ElasticBeanstalk::Environment',
@@ -38,7 +37,9 @@ def wildcard_match(pattern = nil, text = nil)
3837
match = text.downcase.match?(regexp)
3938

4039
unless match
41-
# Assuming a logging mechanism exists
40+
OpenTelemetry.logger.debug(
41+
"WildcardMatch: no match found for #{text} against pattern #{pattern}"
42+
)
4243
end
4344

4445
match

0 commit comments

Comments
 (0)