wip

Author: kirs

instrumentation/pg/test/opentelemetry/instrumentation/pg/instrumentation_test.rb

@@ -136,23 +136,6 @@
         _(connect_span.attributes['peer.service']).must_equal 'readonly:postgres'
       end
 
-      it 'sets unix socket attributes when connecting via socket' do
-        skip 'socket test requires no host/port' if host || port
-
-        conn = PG::Connection.open(
-          user: user,
-          dbname: dbname,
-          password: password
-        )
-        conn.close
-
-        connect_span = exporter.finished_spans.first
-        _(connect_span.name).must_equal 'connect'
-        _(connect_span.attributes['db.system']).must_equal 'postgresql'
-        _(connect_span.attributes['net.sock.family']).must_equal 'unix'
-        _(connect_span.attributes['net.peer.name']).must_match %r{^/}
-      end
-
       it 'records connection errors' do
         expect do
           PG::Connection.open(
@@ -448,6 +431,17 @@
         _(last_span.attributes['net.peer.port']).must_be_nil
         _(last_span.attributes['net.sock.family']).must_equal 'unix'
       end
+
+      it 'sets attributes for the connect span' do
+        client.query('SELECT 1')
+
+        raise exporter.finished_spans.map(&:name).inspect
+        connect_span = exporter.finished_spans.first
+        _(connect_span.name).must_equal 'connect'
+        _(connect_span.attributes['db.system']).must_equal 'postgresql'
+        _(connect_span.attributes['net.sock.family']).must_equal 'unix'
+        _(connect_span.attributes['net.peer.name']).must_match %r{^/}
+      end
     end
 
     describe 'when connection has multiple hosts' do