capture exceptions and close span in perform

Author: mspletz

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/dup/easy.rb

@@ -36,8 +36,15 @@ def headers=(headers)
             end
 
             def perform
-              otel_before_request
-              super
+              begin
+                otel_before_request
+                super
+              rescue StandardError => e
+                # If an exception occurs before we can call `complete`, we should add and error status and close the span
+                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+                @otel_span&.finish
+                @otel_span = nil
+              end
             end
 
             def complete

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/old/easy.rb

@@ -33,8 +33,15 @@ def headers=(headers)
             end
 
             def perform
-              otel_before_request
-              super
+              begin
+                otel_before_request
+                super
+              rescue StandardError => e
+                # If an exception occurs before we can call `complete`, we should add and error status and close the span
+                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+                @otel_span&.finish
+                @otel_span = nil
+              end
             end
 
             def complete

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/stable/easy.rb

@@ -36,8 +36,15 @@ def headers=(headers)
             end
 
             def perform
-              otel_before_request
-              super
+              begin
+                otel_before_request
+                super
+              rescue StandardError => e
+                # If an exception occurs before we can call `complete`, we should add and error status and close the span
+                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+                @otel_span&.finish
+                @otel_span = nil
+              end
             end
 
             def complete

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/dup/instrumentation_test.rb

@@ -82,6 +82,26 @@
             end
           end
         end
+
+        it 'when the perform fails before complete with an exception' do
+          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+            easy.perform
+
+            # NOTE: check the finished spans since we expect to have closed it
+            span = exporter.finished_spans.first
+            _(span.name).must_equal 'HTTP'
+            _(span.attributes['http.method']).must_equal 'N/A'
+            _(span.attributes['http.status_code']).must_be_nil
+            _(span.attributes['http.url']).must_equal 'http://example.com/test'
+            _(span.attributes['http.request.method']).must_equal '_OTHER'
+            _(span.attributes['http.response.status_code']).must_be_nil
+            _(span.attributes['url.full']).must_equal 'http://example.com/test'
+            _(span.status.code).must_equal(
+              OpenTelemetry::Trace::Status::ERROR
+            )
+            _(easy.instance_eval { @otel_span }).must_be_nil
+            end
+        end
       end
 
       describe '#complete' do

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/old/instrumentation_test.rb

@@ -77,6 +77,23 @@
             end
           end
         end
+
+        it 'when the perform fails before complete with an exception' do
+          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+            easy.perform
+
+            # NOTE: check the finished spans since we expect to have closed it
+            span = exporter.finished_spans.first
+            _(span.name).must_equal 'HTTP N/A'
+            _(span.attributes['http.method']).must_equal 'N/A'
+            _(span.attributes['http.status_code']).must_be_nil
+            _(span.attributes['http.url']).must_equal 'http://example.com/test'
+            _(span.status.code).must_equal(
+              OpenTelemetry::Trace::Status::ERROR
+            )
+            _(easy.instance_eval { @otel_span }).must_be_nil
+            end
+        end
       end
 
       describe '#complete' do
@@ -105,6 +122,7 @@ def stub_response(options)
 
         it 'when response is not successful' do
           stub_response(response_code: 500) do
+            binding.pry
             _(span.name).must_equal 'HTTP N/A'
             _(span.attributes['http.method']).must_equal 'N/A'
             _(span.attributes['http.status_code']).must_equal 500

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/stable/instrumentation_test.rb

@@ -78,6 +78,23 @@
             end
           end
         end
+
+        it 'when the perform fails before complete with an exception' do
+          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+            easy.perform
+
+            # NOTE: check the finished spans since we expect to have closed it
+            span = exporter.finished_spans.first
+            _(span.name).must_equal 'HTTP'
+            _(span.attributes['http.request.method']).must_equal '_OTHER'
+            _(span.attributes['http.response.status_code']).must_be_nil
+            _(span.attributes['url.full']).must_equal 'http://example.com/test'
+            _(span.status.code).must_equal(
+              OpenTelemetry::Trace::Status::ERROR
+            )
+            _(easy.instance_eval { @otel_span }).must_be_nil
+            end
+        end
       end
 
       describe '#complete' do