Skip to content

Commit a6341e9

Browse files
committed
squash: fix em
1 parent a5fb642 commit a6341e9

File tree

7 files changed

+25
-31
lines changed

7 files changed

+25
-31
lines changed

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/old/easy.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ def otel_span_started?
8989
private
9090

9191
def span_creation_attributes(span_data)
92-
instrumentation_attrs = {
93-
}
92+
instrumentation_attrs = {}
9493

9594
uri = _otel_cleanse_uri(url)
9695
if uri

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/stable/easy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ def otel_span_started?
8989
private
9090

9191
def span_creation_attributes(span_data)
92-
instrumentation_attrs = { }
92+
instrumentation_attrs = {}
9393

9494
uri = _otel_cleanse_uri(url)
9595
if uri

instrumentation/excon/lib/opentelemetry/instrumentation/excon/middlewares/stable/tracer_middleware.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,11 @@ def request_call(datum)
1919

2020
span_data = HttpHelper.span_attrs_for(datum[:method], semconv: :stable)
2121

22-
attributes = { 'url.scheme' => datum[:scheme],
23-
'url.path' => datum[:path],
24-
'url.full' => OpenTelemetry::Common::Utilities.cleanse_url(::Excon::Utils.request_uri(datum)),
25-
'server.address' => datum[:hostname],
26-
'server.port' => datum[:port]
27-
}
22+
attributes = { 'url.scheme' => datum[:scheme],
23+
'url.path' => datum[:path],
24+
'url.full' => OpenTelemetry::Common::Utilities.cleanse_url(::Excon::Utils.request_uri(datum)),
25+
'server.address' => datum[:hostname],
26+
'server.port' => datum[:port] }
2827
attributes['url.query'] = datum[:query] if datum[:query]
2928
peer_service = Excon::Instrumentation.instance.config[:peer_service]
3029
attributes[OpenTelemetry::SemanticConventions::Trace::PEER_SERVICE] = peer_service if peer_service

instrumentation/http_client/lib/opentelemetry/instrumentation/http_client/patches/stable/client.rb

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,11 @@ def do_get_block(req, proxy, conn, &)
2323

2424
span_data = HttpHelper.span_attrs_for(request_method, semconv: :stable)
2525

26-
attributes = { 'url.scheme' => uri.scheme,
27-
'url.path' => uri.path,
28-
'url.full' => url,
29-
'server.address' => uri.host,
30-
'server.port' => uri.port
31-
}.merge!(span_data.attributes)
26+
attributes = { 'url.scheme' => uri.scheme,
27+
'url.path' => uri.path,
28+
'url.full' => url,
29+
'server.address' => uri.host,
30+
'server.port' => uri.port }.merge!(span_data.attributes)
3231

3332
attributes['url.query'] = uri.query unless uri.query.nil?
3433

instrumentation/net_http/lib/opentelemetry/instrumentation/net/http/patches/dup/instrumentation.rb

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,12 @@ def request(req, body = nil, &)
2525

2626
span_data = HttpHelper.span_attrs_for(req.method, semconv: :dup)
2727

28-
attributes = { OpenTelemetry::SemanticConventions::Trace::HTTP_SCHEME => USE_SSL_TO_SCHEME[use_ssl?],
29-
OpenTelemetry::SemanticConventions::Trace::HTTP_TARGET => req.path,
30-
OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME => @address,
31-
OpenTelemetry::SemanticConventions::Trace::NET_PEER_PORT => @port, 'url.scheme' => USE_SSL_TO_SCHEME[use_ssl?],
32-
'server.address' => @address,
33-
'server.port' => @port
34-
}
28+
attributes = { OpenTelemetry::SemanticConventions::Trace::HTTP_SCHEME => USE_SSL_TO_SCHEME[use_ssl?],
29+
OpenTelemetry::SemanticConventions::Trace::HTTP_TARGET => req.path,
30+
OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME => @address,
31+
OpenTelemetry::SemanticConventions::Trace::NET_PEER_PORT => @port, 'url.scheme' => USE_SSL_TO_SCHEME[use_ssl?],
32+
'server.address' => @address,
33+
'server.port' => @port }
3534
path, query = split_path_and_query(req.path)
3635
attributes['url.path'] = path
3736
attributes['url.query'] = query if query

instrumentation/net_http/lib/opentelemetry/instrumentation/net/http/patches/old/instrumentation.rb

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@ def request(req, body = nil, &)
2525

2626
span_data = HttpHelper.span_attrs_for(req.method, semconv: :old)
2727

28-
attributes = { OpenTelemetry::SemanticConventions::Trace::HTTP_SCHEME => USE_SSL_TO_SCHEME[use_ssl?],
29-
OpenTelemetry::SemanticConventions::Trace::HTTP_TARGET => req.path,
30-
OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME => @address,
31-
OpenTelemetry::SemanticConventions::Trace::NET_PEER_PORT => @port
32-
}.merge!(span_data.attributes)
28+
attributes = { OpenTelemetry::SemanticConventions::Trace::HTTP_SCHEME => USE_SSL_TO_SCHEME[use_ssl?],
29+
OpenTelemetry::SemanticConventions::Trace::HTTP_TARGET => req.path,
30+
OpenTelemetry::SemanticConventions::Trace::NET_PEER_NAME => @address,
31+
OpenTelemetry::SemanticConventions::Trace::NET_PEER_PORT => @port }.merge!(span_data.attributes)
3332

3433
tracer.in_span(
3534
span_data.span_name,

instrumentation/net_http/lib/opentelemetry/instrumentation/net/http/patches/stable/instrumentation.rb

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ def request(req, body = nil, &)
2525

2626
span_data = HttpHelper.span_attrs_for(req.method, semconv: :stable)
2727

28-
attributes = { 'url.scheme' => USE_SSL_TO_SCHEME[use_ssl?],
29-
'server.address' => @address,
30-
'server.port' => @port
31-
}
28+
attributes = { 'url.scheme' => USE_SSL_TO_SCHEME[use_ssl?],
29+
'server.address' => @address,
30+
'server.port' => @port }
3231
path, query = split_path_and_query(req.path)
3332
attributes['url.path'] = path
3433
attributes['url.query'] = query if query

0 commit comments

Comments
 (0)