Skip to content

Commit ad9ccf6

Browse files
committed
fix: Make the unmaintained versions of rdkafka-ruby unsupported
1 parent eeec9d1 commit ad9ccf6

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

instrumentation/rdkafka/Appraisals

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
#
55
# SPDX-License-Identifier: Apache-2.0
66

7-
%w[0.12.0 0.13.0 0.14.0 0.15.0 0.16.0 0.17.0 0.18.0 0.19.0 0.20.0 0.21.0].each do |version|
7+
%w[0.18.0 0.19.0 0.20.0 0.21.0].each do |version|
88
appraise "rdkafka-#{version}" do
99
gem 'rdkafka', "~> #{version}"
1010
end

instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/instrumentation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Rdkafka
1111
class Instrumentation < OpenTelemetry::Instrumentation::Base
1212
compatible do
1313
gem_version = Gem::Version.new(::Rdkafka::VERSION)
14-
Gem::Requirement.new('>= 0.10.0').satisfied_by?(gem_version)
14+
Gem::Requirement.new('>= 0.18.0').satisfied_by?(gem_version)
1515
end
1616

1717
install do |_config|

instrumentation/rdkafka/lib/opentelemetry/instrumentation/rdkafka/patches/consumer.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,7 @@ module Rdkafka
1010
module Patches
1111
# The Consumer module contains the instrumentation patch for the Consumer class
1212
module Consumer
13-
GETTER = if Gem::Version.new(::Rdkafka::VERSION) >= Gem::Version.new('0.13.0')
14-
Context::Propagation.text_map_getter
15-
else
16-
OpenTelemetry::Common::Propagation.symbol_key_getter
17-
end
13+
GETTER = Context::Propagation.text_map_getter
1814
private_constant :GETTER
1915

2016
def each

0 commit comments

Comments
 (0)