Skip to content

Commit afff1d9

Browse files
committed
change flag name
1 parent cd5eb2d commit afff1d9

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

instrumentation/faraday/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ To install the instrumentation, call `use` with the name of the instrumentation.
1919
```ruby
2020
OpenTelemetry::SDK.configure do |c|
2121
c.use 'OpenTelemetry::Instrumentation::Faraday'
22-
suppress_internal_instrumentation: true
22+
enable_internal_instrumentation: false
2323
end
2424
```
2525

@@ -33,8 +33,8 @@ end
3333

3434
### Configuration options
3535
This instrumentation offers the following configuration options:
36-
* `suppress_internal_instrumentation` (default: `false`): When set to `true`, any spans with
37-
span kind of `internal` are suppressed from traces.
36+
* `enable_internal_instrumentation` (default: `false`): When set to `true`, any spans with
37+
span kind of `internal` are included in traces.
3838

3939
## Examples
4040

instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/instrumentation.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ class Instrumentation < OpenTelemetry::Instrumentation::Base
2828

2929
option :span_kind, default: :client, validate: %i[client internal]
3030
option :peer_service, default: nil, validate: :string
31-
option :suppress_internal_instrumentation, default: false, validate: :boolean
31+
option :enable_internal_instrumentation, default: false, validate: :boolean
3232

3333
private
3434

instrumentation/faraday/lib/opentelemetry/instrumentation/faraday/middlewares/tracer_middleware.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ def call(env)
4040
) do |span|
4141
OpenTelemetry.propagation.inject(env.request_headers)
4242

43-
if config[:suppress_internal_instrumentation]
43+
if config[:enable_internal_instrumentation] == false
4444
OpenTelemetry::Common::Utilities.untraced do
4545
app.call(env).on_complete { |resp| trace_response(span, resp.status) }
4646
end

0 commit comments

Comments
 (0)