fix rubocop errors

Author: mspletz

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/dup/easy.rb

@@ -36,15 +36,13 @@ def headers=(headers)
             end
 
             def perform
-              begin
-                otel_before_request
-                super
-              rescue StandardError => e
-                # If an exception occurs before we can call `complete`, we should add and error status and close the span
-                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
-                @otel_span&.finish
-                @otel_span = nil
-              end
+              otel_before_request
+              super
+            rescue StandardError => e
+              # If an exception occurs before we can call `complete`, we should add and error status and close the span
+              @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+              @otel_span&.finish
+              @otel_span = nil
             end
 
             def complete

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/old/easy.rb

@@ -33,15 +33,13 @@ def headers=(headers)
             end
 
             def perform
-              begin
-                otel_before_request
-                super
-              rescue StandardError => e
-                # If an exception occurs before we can call `complete`, we should add and error status and close the span
-                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
-                @otel_span&.finish
-                @otel_span = nil
-              end
+              otel_before_request
+              super
+            rescue StandardError => e
+              # If an exception occurs before we can call `complete`, we should add and error status and close the span
+              @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+              @otel_span&.finish
+              @otel_span = nil
             end
 
             def complete

instrumentation/ethon/lib/opentelemetry/instrumentation/ethon/patches/stable/easy.rb

@@ -36,15 +36,13 @@ def headers=(headers)
             end
 
             def perform
-              begin
-                otel_before_request
-                super
-              rescue StandardError => e
-                # If an exception occurs before we can call `complete`, we should add and error status and close the span
-                @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
-                @otel_span&.finish
-                @otel_span = nil
-              end
+              otel_before_request
+              super
+            rescue StandardError => e
+              # If an exception occurs before we can call `complete`, we should add and error status and close the span
+              @otel_span&.status = OpenTelemetry::Trace::Status.error("Request threw an exception: #{e.message}")
+              @otel_span&.finish
+              @otel_span = nil
             end
 
             def complete

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/dup/instrumentation_test.rb

@@ -84,7 +84,7 @@
         end
 
         it 'when the perform fails before complete with an exception' do
-          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+          Ethon::Curl.stub(:easy_perform, ->(_handle) { raise StandardError, 'Connection failed' }) do
             easy.perform
 
             # NOTE: check the finished spans since we expect to have closed it
@@ -100,7 +100,7 @@
               OpenTelemetry::Trace::Status::ERROR
             )
             _(easy.instance_eval { @otel_span }).must_be_nil
-            end
+          end
         end
       end
 

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/old/instrumentation_test.rb

@@ -79,7 +79,7 @@
         end
 
         it 'when the perform fails before complete with an exception' do
-          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+          Ethon::Curl.stub(:easy_perform, ->(_handle) { raise StandardError, 'Connection failed' }) do
             easy.perform
 
             # NOTE: check the finished spans since we expect to have closed it
@@ -92,7 +92,7 @@
               OpenTelemetry::Trace::Status::ERROR
             )
             _(easy.instance_eval { @otel_span }).must_be_nil
-            end
+          end
         end
       end
 

instrumentation/ethon/test/opentelemetry/instrumentation/ethon/stable/instrumentation_test.rb

@@ -80,7 +80,7 @@
         end
 
         it 'when the perform fails before complete with an exception' do
-          Ethon::Curl.stub(:easy_perform, ->(handle) { raise StandardError, "Connection failed" }) do
+          Ethon::Curl.stub(:easy_perform, ->(_handle) { raise StandardError, 'Connection failed' }) do
             easy.perform
 
             # NOTE: check the finished spans since we expect to have closed it
@@ -93,7 +93,7 @@
               OpenTelemetry::Trace::Status::ERROR
             )
             _(easy.instance_eval { @otel_span }).must_be_nil
-            end
+          end
         end
       end