wip

Author: zvkemp

instrumentation/base/lib/opentelemetry/instrumentation/base.rb

@@ -192,7 +192,7 @@ def infer_version
         end
       end
 
-      attr_reader :name, :version, :config, :installed, :tracer
+      attr_reader :name, :version, :config, :installed, :tracer, :meter
 
       alias installed? installed
 
@@ -207,7 +207,8 @@ def initialize(name, version, install_blk, present_blk,
         @config = {}
         @installed = false
         @options = options
-        @tracer = OpenTelemetry::Trace::Tracer.new
+        @tracer = OpenTelemetry::Trace::Tracer.new # default no-op tracer
+        @meter = OpenTelemetry::Metrics::Meter.new # default no-op meter
       end
       # rubocop:enable Metrics/ParameterLists
 
@@ -224,7 +225,11 @@ def install(config = {})
 
         instance_exec(@config, &@install_blk)
         @tracer = OpenTelemetry.tracer_provider.tracer(name, version)
+
         @installed = true
+
+        return unless config[:metrics]
+        @meter = OpenTelemetry.meter_provider.meter(name, version: version)
       end
 
       # Whether or not this instrumentation is installable in the current process. Will

instrumentation/concurrent_ruby/opentelemetry-instrumentation-concurrent_ruby.gemspec

@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 3.0'
 
   spec.add_dependency 'opentelemetry-api', '~> 1.0'
+  spec.add_dependency 'opentelemetry-metrics-api', '~> 1.0'
   spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.22.1'
 
   spec.add_development_dependency 'appraisal', '~> 2.5'

instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/instrumentation.rb

@@ -107,6 +107,7 @@ class Instrumentation < OpenTelemetry::Instrumentation::Base
         option :trace_poller_wait,           default: false, validate: :boolean
         option :trace_processor_process_one, default: false, validate: :boolean
         option :peer_service,                default: nil,   validate: :string
+        option :metrics,                     default: false, validate: :boolean
 
         private
 

instrumentation/sidekiq/lib/opentelemetry/instrumentation/sidekiq/middlewares/client/tracer_middleware.rb

@@ -33,6 +33,23 @@ def call(_worker_class, job, _queue, _redis_pool)
                 OpenTelemetry.propagation.inject(job)
                 span.add_event('created_at', timestamp: job['created_at'])
                 yield
+              end.tap do
+                # FIXME: is it possible to detect failures here? Does sidekiq bubble them up the middlewares?
+                if instrumentation_config[:metrics]
+                  begin
+                    counter_attributes = {
+                      'messaging.operation.name' => 'enqueue', # FIXME: metrics semconv
+                      'messaging.system' => 'sidekiq', # FIXME: metrics semconv
+                      'messaging.destination.name' => job['queue'] # FIXME: metrics semconv
+                      # server.address => # FIXME: required if available
+                      # messaging.destination.partition.id => FIXME: recommended
+                      # server.port => # FIXME: recommended
+                    }
+
+                    counter = meter.create_counter('messaging.client.sent.messages')
+                    counter.add(1, attributes: counter_attributes)
+                  end
+                end
               end
             end
 
@@ -45,6 +62,10 @@ def instrumentation_config
             def tracer
               Sidekiq::Instrumentation.instance.tracer
             end
+
+            def meter
+              Sidekiq::Instrumentation.instance.meter
+            end
           end
         end
       end