Cleanup

Author: hannahramadan

instrumentation/http/test/instrumentation/http/patches/dup/client_test.rb

@@ -47,7 +47,6 @@
   describe 'installation' do
     it 'applies the correct patch when stability options include only http/dup and database' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup, database'
-
       # simulate a fresh install:
       instrumentation.instance_variable_set(:@installed, false)
       instrumentation.install(config)
@@ -57,7 +56,6 @@
 
     it 'applies the http/dup patch and excludes the Stable patch when both http and http/dup are present' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http, http/dup'
-
       # simulate a fresh install:
       instrumentation.instance_variable_set(:@installed, false)
       instrumentation.install(config)
@@ -72,15 +70,13 @@
       HTTP.get('http://example.com/success')
       _(exporter.finished_spans.size).must_equal(1)
       _(span.name).must_equal 'HTTP GET'
-
       # Old semantic conventions
       _(span.attributes['http.method']).must_equal 'GET'
       _(span.attributes['http.scheme']).must_equal 'http'
       _(span.attributes['http.status_code']).must_equal 200
       _(span.attributes['http.target']).must_equal '/success'
       _(span.attributes['net.peer.name']).must_equal 'example.com'
       _(span.attributes['net.peer.port']).must_equal 80
-
       # Stable semantic conventions
       _(span.attributes['http.request.method']).must_equal 'GET'
       _(span.attributes['url.scheme']).must_equal 'http'

instrumentation/http/test/instrumentation/http/patches/dup/connection_test.rb

@@ -31,7 +31,7 @@
   describe 'installation' do
     it 'installs the patch when env var has multiple configs' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup, database'
-      instrumentation.install({}) # simulate a fresh install:
+      instrumentation.install({}) # simulate a fresh install
 
       _(HTTP::Connection.ancestors).must_include OpenTelemetry::Instrumentation::HTTP::Patches::Dup::Connection
     end
@@ -51,11 +51,9 @@
 
       _(exporter.finished_spans.size).must_equal(2)
       _(span.name).must_equal 'HTTP CONNECT'
-
       # Old semantic conventions
       _(span.attributes['net.peer.name']).must_equal('localhost')
       _(span.attributes['net.peer.port']).wont_be_nil
-
       # Stable semantic conventions
       _(span.attributes['server.address']).must_equal('localhost')
       _(span.attributes['server.port']).wont_be_nil

instrumentation/http/test/instrumentation/http/patches/old/client_test.rb

@@ -45,7 +45,6 @@
   describe 'installation' do
     it 'applies the correct patch when stability options do not include HTTP stability modes' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'database'
-
       # simulate a fresh install:
       instrumentation.instance_variable_set(:@installed, false)
       instrumentation.install(config)

instrumentation/http/test/instrumentation/http/patches/old/connection.rb

@@ -27,10 +27,7 @@
   describe 'installation' do
     it 'applies the correct patch when stability options do not include HTTP stability modes' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'database'
-
-      # simulate a fresh install:
-      instrumentation.instance_variable_set(:@installed, false)
-      instrumentation.install(config)
+      instrumentation.install({}) # simulate a fresh install
 
       _(HTTP::Connection.ancestors).must_include OpenTelemetry::Instrumentation::HTTP::Patches::Old::Connection
     end

instrumentation/http/test/instrumentation/http/patches/stable/client_test.rb

@@ -48,7 +48,6 @@
   describe 'installation' do
     it 'applies the correct patch when stability options include only http/dup and database' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http, database'
-
       # simulate a fresh install:
       instrumentation.instance_variable_set(:@installed, false)
       instrumentation.install(config)

instrumentation/http/test/instrumentation/http/patches/stable/connection.rb

@@ -31,7 +31,7 @@
   describe 'installation' do
     it 'installs the patch when env var has multiple configs' do
       ENV['OTEL_SEMCONV_STABILITY_OPT_IN'] = 'http/dup, database'
-      instrumentation.install({}) # simulate a fresh install:
+      instrumentation.install({}) # simulate a fresh install
 
       _(HTTP::Connection.ancestors).must_include OpenTelemetry::Instrumentation::HTTP::Patches::Dup::Connection
     end