address comments

Author: jj22ee

sampler/xray/example/xray_sampling_on_rails_demonstration.ru

@@ -43,8 +43,9 @@ class WelcomeController < ActionController::Base
   end
 end
 
-ENV['OTEL_TRACES_EXPORTER'] = 'console'
-ENV['OTEL_SERVICE_NAME'] = 'xray-sampler-on-rails-service'
+ENV['OTEL_TRACES_EXPORTER'] ||= 'console'
+ENV['OTEL_SERVICE_NAME'] ||= 'xray-sampler-on-rails-service'
+
 OpenTelemetry::SDK.configure do |c|
   c.use_all({ 'OpenTelemetry::Instrumentation::ActiveRecord' => { enabled: false } })
 end
@@ -59,7 +60,7 @@ run App
 
 #### Running and using the Sample App
 # To run this example run the `rackup` command with this file
-# Example: rackup trace_request_demonstration.ru
+# Example: rackup xray_sampling_on_rails_demonstration.ru
 # Navigate to http://localhost:9292/
 # Spans for any requests sampled by the X-Ray Sampler will appear in the console
 

sampler/xray/lib/opentelemetry/sampler/xray/rate_limiter.rb

@@ -20,7 +20,7 @@ def initialize(quota, max_balance_in_seconds = 1)
         end
 
         def take(cost = 1)
-          return false if @quota.zero?
+          return false if @quota <= 0
 
           quota_per_millis = @quota / 1000.0
 

sampler/xray/test/rate_limiter_test.rb

@@ -47,4 +47,18 @@
     end
     assert_equal 30, spent
   end
+
+  it 'test_take_with_zero_quota' do
+    limiter = OpenTelemetry::Sampler::XRay::RateLimiter.new(0, 1)
+
+    # Zero quota should always return false
+    refute limiter.take(1)
+  end
+
+  it 'test_take_with_negative_quota' do
+    limiter = OpenTelemetry::Sampler::XRay::RateLimiter.new(-5, 1)
+
+    # Negative quota should always return false
+    refute limiter.take(1)
+  end
 end