Skip to content

Commit ea06e06

Browse files
committed
chore: Fix release matching directories
HTTP / HTTPX SQL / Sql Obfuscation + Sql Processors All these gems match on the substring and cause toys to initiate releases when changes have not been made to accidentally matching gems. Adding a / should fix the match problem.
1 parent f65d4e3 commit ea06e06

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

.toys/.data/releases.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,11 @@ gems:
3939
version_constant: [OpenTelemetry, Instrumentation, ActiveStorage, VERSION]
4040

4141
- name: opentelemetry-helpers-sql
42-
directory: helpers/sql
42+
# we append a slash here to avoid the naive substring start_with? directory-matching condition in underlying toys gem
43+
# which casues helpers/sql to incorrectly match when changes occur in helpers/sql-processor or helpers/sql-obfuscation
44+
# https://github.com/dazuma/toys/blob/17ed449da8299f272b834470ff6b279a59e8070b/.toys/release/.lib/release_utils.rb#L436
45+
# https://github.com/open-telemetry/opentelemetry-ruby-contrib/pull/1727
46+
directory: helpers/sql/
4347
version_constant: [OpenTelemetry, Helpers, Sql, VERSION]
4448

4549
- name: opentelemetry-instrumentation-gruf
@@ -130,7 +134,11 @@ gems:
130134
version_constant: [OpenTelemetry, Instrumentation, LMDB, VERSION]
131135

132136
- name: opentelemetry-instrumentation-http
133-
directory: instrumentation/http
137+
# we append a slash here to avoid the naive substring start_with? directory-matching condition in underlying toys gem
138+
# which casues instrumentation/http to incorrectly match when changes occur in instrumentation/httpx
139+
# https://github.com/dazuma/toys/blob/17ed449da8299f272b834470ff6b279a59e8070b/.toys/release/.lib/release_utils.rb#L436
140+
# https://github.com/open-telemetry/opentelemetry-ruby-contrib/issues/1512
141+
directory: instrumentation/http/
134142
version_constant: [OpenTelemetry, Instrumentation, HTTP, VERSION]
135143

136144
- name: opentelemetry-instrumentation-graphql

0 commit comments

Comments
 (0)