Fix: CI on old rubies

Author: hannahramadan

instrumentation/net_http/test/opentelemetry/instrumentation/net/http/dup/instrumentation_test.rb

@@ -201,16 +201,7 @@
         # this works because http://bazqux.com is reachable site; try http://asdfasdfsef.com will fail
         uri = URI.parse('http://bazqux.com')
         http = Net::HTTP.new(uri.host, uri.port)
-        
-        fake_socket = Object.new
-        def fake_socket.setsockopt(*args); end
-        def fake_socket.close; end
-
-        # Replace the TCP socket creation with our fake socket
-        TCPSocket.stub(:open, fake_socket) do
-          http.send(:connect)
-        end
-
+        http.send(:connect)
         http.send(:do_finish)
         _(exporter.finished_spans.size).must_equal 0
       end
@@ -229,7 +220,16 @@ def fake_socket.close; end
       it 'creates a span on connect for a non-ignored request' do
         uri = URI.parse('http://example.com')
         http = Net::HTTP.new(uri.host, uri.port)
-        http.send(:connect)
+
+        fake_socket = Object.new
+        def fake_socket.setsockopt(*args); end
+        def fake_socket.close; end
+
+        # Replace the TCP socket creation with our fake socket
+        TCPSocket.stub(:open, fake_socket) do
+          http.send(:connect)
+        end
+
         http.send(:do_finish)
         _(exporter.finished_spans.size).must_equal 1
         _(span.name).must_equal('connect')

instrumentation/net_http/test/opentelemetry/instrumentation/net/http/old/instrumentation_test.rb

@@ -156,16 +156,7 @@
         # this works because http://bazqux.com is reachable site; try http://asdfasdfsef.com will fail
         uri = URI.parse('http://bazqux.com')
         http = Net::HTTP.new(uri.host, uri.port)
-
-        fake_socket = Object.new
-        def fake_socket.setsockopt(*args); end
-        def fake_socket.close; end
-
-        # Replace the TCP socket creation with our fake socket
-        TCPSocket.stub(:open, fake_socket) do
-          http.send(:connect)
-        end
-
+        http.send(:connect)
         http.send(:do_finish)
         _(exporter.finished_spans.size).must_equal 0
       end

instrumentation/net_http/test/opentelemetry/instrumentation/net/http/stable/instrumentation_test.rb

@@ -172,16 +172,7 @@
         # this works because http://bazqux.com is reachable site; try http://asdfasdfsef.com will fail
         uri = URI.parse('http://bazqux.com')
         http = Net::HTTP.new(uri.host, uri.port)
-
-        fake_socket = Object.new
-        def fake_socket.setsockopt(*args); end
-        def fake_socket.close; end
-
-        # Replace the TCP socket creation with our fake socket
-        TCPSocket.stub(:open, fake_socket) do
-          http.send(:connect)
-        end
-
+        http.send(:connect)
         http.send(:do_finish)
         _(exporter.finished_spans.size).must_equal 0
       end
@@ -197,7 +188,16 @@ def fake_socket.close; end
       it 'creates a span on connect for a non-ignored request' do
         uri = URI.parse('http://example.com')
         http = Net::HTTP.new(uri.host, uri.port)
-        http.send(:connect)
+
+        fake_socket = Object.new
+        def fake_socket.setsockopt(*args); end
+        def fake_socket.close; end
+
+        # Replace the TCP socket creation with our fake socket
+        TCPSocket.stub(:open, fake_socket) do
+          http.send(:connect)
+        end
+
         http.send(:do_finish)
         _(exporter.finished_spans.size).must_equal 1
         _(span.name).must_equal('connect')