Active Record Instrumentation bug in combination with permanent_records gem.

[mikesapienza]

opentelemetry-ruby-contrib/instrumentation/active_record/lib/opentelemetry/instrumentation/active_record/patches/persistence.rb

Line 20 in 25e9814

def destroy

When using the OTEL instrumentation gem with the permanent_records gem, this monkey patch causes an argument error because permanent records allows (:force) to be passed to destroy. Argument forwarding can be added to the destroy method to fix this. We have it monkey patched in our app would it be possible to get this fixed in the gem?

module OpenTelemetry
    module Instrumentation
      module ActiveRecord
        module Patches
          module Persistence
            def destroy(...)
              tracer.in_span("#{self.class}#destroy") do
                super
              end
            end
          end
        end
      end
    end
  end

[arielvalentin]

@mikesapienza The ActiveRecord persistence module does not accept any parameters.

The permanent_records gem is altering the public API of a gem it does not own.

Propagating this change would in turn change the ActiveRecord interface for users that do not use permanent_records so we would not accept such a change in this repository.

If you could make a case for changing the destroy method in the upstream Rails repo, I think we would be happy to support it here but until then we would not be willing to take this on.