Skip to content

Enable CSRF Protection protect #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Enable CSRF Protection protect #1209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a5e648
Enable CSRF Protection protect
rhythmdesai404 May 28, 2024
33c54d3
Merge branch 'main' into protect_from_forgery
rhythmdesai404 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions instrumentation/action_pack/test/test_helpers/controllers/example_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
class ExampleController < ActionController::Base
include ::Rails.application.routes.url_helpers

# Enable CSRF Protection
protect_from_forgery with: :exception
Comment on lines +10 to +11
Copy link
Contributor

@kaylareopelle kaylareopelle Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rhythmdesai404! Since I haven't heard back from you after Eric's comment earlier, I'm assuming this is ready for review.

I'm curious about why we need to turn this on. This is test code, and shouldn't impact the user. Why do we need to enable it here?

Copy link
Author

@rhythmdesai404 rhythmdesai404 Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kaylareopelle! Great question. Even though it's test code, enabling CSRF protection is important because it helps ensure that the tests accurately reflect the security measures in place for the actual application. By turning it on, we:
Simulate Real Conditions: Make sure the test environment mimics the real application environment, including its security features.
Consistency: Maintain consistency in how the application handles requests, whether in testing or in production.
In short, enabling CSRF protection in test code helps ensure that your application is secure and behaves as expected in all scenarios.

Copy link
Contributor

@kaylareopelle kaylareopelle Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the context, @rhythmdesai404! That makes sense to me. If you'd still like to see this change, please reopen the PR and we'll give it a look.


def ok
render plain: 'actually ok'
end
Expand Down
Loading