Skip to content

Conversation

@ymtdzzz
Copy link
Contributor

@ymtdzzz ymtdzzz commented Jan 13, 2025

closes: #1332

This PR solves rubocop errors in the codes generated from bin/instrumentation_generator.

Test

❯ bin/instrumentation_generator sample_package
❯ cd instrumentation/sample_package
❯ bundle install
❯ bundle exec rake rubocop
Running RuboCop...
Inspecting 11 files
...........
                                                                                                                                                                                                                                                                                                                     
11 files inspected, no offenses detected
                                                                                                                                                                                                                                                                                                                     
Tip: Based on detected gems, the following RuboCop extension libraries might be helpful:
  * rubocop-minitest (https://rubygems.org/gems/rubocop-minitest)
  * rubocop-rake (https://rubygems.org/gems/rubocop-rake)
                                                                                                                                                                                                                                                                                                                     
You can opt out of this message by adding the following to your config (see https://docs.rubocop.org/rubocop/extensions.html#extension-suggestions for more options):
  AllCops:
    SuggestExtensions: false

Copy link
Contributor

@plantfansam plantfansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaylareopelle kaylareopelle merged commit 00d379c into open-telemetry:main Jan 13, 2025
56 checks passed
@ymtdzzz ymtdzzz deleted the fix/rubocop_errors_in_inst_gen branch January 14, 2025 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generated codes from bin/instrumentation_generator fail in rubocop

4 participants