-
Notifications
You must be signed in to change notification settings - Fork 226
feat: AWS X-Ray Remote Sampler Part 1 - Initial Classes and Rules Poller Implementation #1453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kaylareopelle I've made the initial PR for X-Ray Sampler, will try to get someone from AWS who is familiar with X-Ray Sampling to help with the review. |
|
Hi @jj22ee, sorry about the delay in response on this one. Getting help from someone from AWS with X-Ray sampling experience would be a huge help. I can take care of the review for the parts related to adding new gems to this repo. |
|
Will be getting help from @lukeina2z for X-Ray Sampler logic review. |
| module Utils | ||
| module_function | ||
|
|
||
| CLOUD_PLATFORM_MAPPING = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list does not match service type from the console. Let's say step fn is not listed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't include all services that are listed from X-Ray Sampling console. Services like APIGW and StepFn has their own dedicated Sampler logic that cannot be configured with OTel Ruby SDK. So this means we only have to care about the other cases like ebs, ec2, ecs, and eks.
Technically we should exclude Lambda too from this list because Lambda's sampling in not configurable, but I believe we include it in the sampler for all other languages for potential future-proofing for when Lambda may support Remote Sampling.
|
Thanks, @lukeina2z for taking a look! And also, thank you, @jj22ee for submitting this PR. Looking forward to the next one! |
…ler Implementation (open-telemetry#1453) * AWS X-Ray Remote Sampler Part 1 - Initial Classes and Rules Poller Implementation * fix workflow job name, fix jruby step * update logging for utils * bump rubocop and rubocop-performance gem versions * update version and dep version --------- Co-authored-by: Kayla Reopelle <[email protected]>
…ler Implementation (open-telemetry#1453) * AWS X-Ray Remote Sampler Part 1 - Initial Classes and Rules Poller Implementation * fix workflow job name, fix jruby step * update logging for utils * bump rubocop and rubocop-performance gem versions * update version and dep version --------- Co-authored-by: Kayla Reopelle <[email protected]>
Description
This is an initial PR to address #1434 in order for OTel Ruby to support X-Ray Remote Sampling. A series of PRs to fully implement this feature will follow this one.
Changes:
sampler/xray/lib/opentelemetry-sampler-xray.rbTesting
Right now, it currently always return a Parent Based decision or a DROP decision as a placeholder.