fix: httpx instrumentation trace context propagation #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoneyryderChuck
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
HoneyryderChuck
force-pushed
the
pr-1404-3
branch
from
d70801e to
c60c8af
Compare
HoneyryderChuck
changed the title
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks for these updates, @HoneyryderChuck! It looks like Rubocop wants documentation for a few of the modules:
lib/opentelemetry/instrumentation/httpx/plugin.rb:104:9: C: Style/Documentation: Missing top-level documentation comment for module OpenTelemetry::Instrumentation::HTTPX::Plugin::RequestMethods.
module RequestMethods
^^^^^^^^^^^^^^^^^^^^^
lib/opentelemetry/instrumentation/httpx/plugin.rb:112:9: C: Style/Documentation: Missing top-level documentation comment for module OpenTelemetry::Instrumentation::HTTPX::Plugin::ConnectionMethods.
module ConnectionMethods
^^^^^^^^^^^^^^^^^^^^^^^^
instrumentation/httpx/lib/opentelemetry/instrumentation/httpx/version.rb
Outdated
Show resolved
Hide resolved
HoneyryderChuck
force-pushed
the
pr-1404-3
branch
from
c60c8af to
d0daeab
Compare
Contributor
Author
|
@kaylareopelle added missing docs. |
instrumentation/httpx/lib/opentelemetry/instrumentation/httpx/plugin.rb
Outdated
Show resolved
Hide resolved
Contributor
|
Hi @HoneyryderChuck, I'm not able to merge this PR at the moment because it hangs on Do you have the ability to update your branch to sync with |
Contributor
|
@HoneyryderChuck I seem to be having trouble syncing your branch with main. Would you mind rebasing? |
HoneyryderChuck
force-pushed
the
pr-1404-3
branch
from
bb666ec to
18bf33f
Compare
Contributor
Author
|
rebased |
fixes the trace context propagation
HoneyryderChuck
force-pushed
the
pr-1404-3
branch
from
18bf33f to
c401864
Compare
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
Apr 30, 2025
…1456) * fix: Follow latest datadog plugin fixes the trace context propagation * chore: do not test anymore against httpx 0.x * chore: correct error description --------- Co-authored-by: Oliver Morgan <[email protected]> Co-authored-by: Ariel Valentin <[email protected]>
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
May 14, 2025
…1456) * fix: Follow latest datadog plugin fixes the trace context propagation * chore: do not test anymore against httpx 0.x * chore: correct error description --------- Co-authored-by: Oliver Morgan <[email protected]> Co-authored-by: Ariel Valentin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should supersede #1404 . It fixes distributed tracing propagation (the aim of the original MR). It also drops support for httpx < 1.x; it may still work with it, but the
webmockintegration with it is no longer made possible.