chore: Add AWS resource detector to releases #1475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiyuan-he
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
kaylareopelle
previously approved these changes
Apr 9, 2025
kaylareopelle
dismissed
their stale review
It looks like there's a few other files needed before we can release. I apologize for missing them in the initial review:
.rubocop.yml: should be able to copy the one in the azure resource detector.yardopts: also able to copy, but will need to replace "Azure" with "AWS"CHAGENLOG.md: This file needs to exist and should only contain the following:
# Release History: opentelemetry-resource-detector-aws
Our release tooling will generate the entries based on the commits since the last release.
Contributor
Author
|
Thanks @kaylareopelle, no worries at at all. Pushed a commit to add the required |
kaylareopelle
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds AWS reource detector to releases.
Related Issues
#34