feat: contribute aws ecs resource detector #1477
Conversation
yiyuan-he
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
yiyuan-he
changed the title
yiyuan-he
force-pushed
the
contribute-ecs-resource-detector
branch
from
b07b5d5 to
ec5c117
Compare
yiyuan-he
changed the title
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you for this PR! I need more time to get deeper into this and run some E2E tests to complete my review. If you know of any AWS ECS experts who are able to help validate things, we'd love their assistance reviewing as well.
| logs_attributes = get_logs_resource(container_metadata) | ||
| resource_attributes.merge!(logs_attributes) | ||
| rescue StandardError => e | ||
| OpenTelemetry.logger.debug("ECS resource detection failed: #{e.message}") |
There was a problem hiding this comment.
What do you think about using the OpenTelemetry.handle_error API for the rescues in this file rather than a debug-level log?
There was a problem hiding this comment.
Thanks Kayla - the suggestion sounds good to me. I'll update the error handling to use this API instead.
I don't know of any AWS ECS experts in the upstream community. However, I can reach out to an ECS expert from my team and have them help take a look.
There was a problem hiding this comment.
Sounds great, thank you!
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks, @yiyuan-he!
3 participants
What does this pull request do?
Adds functionality for ECS resource detection to AWS resource detector gem. It is similar to the implementation for Python.
Related Issues
#34