chore: only prepend Dalli patch if binary protocol defined #1489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickamorim
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
fbogsany
changed the title
fbogsany
approved these changes
Apr 17, 2025
nickamorim
changed the title
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
Apr 30, 2025
…try#1489) chore: only prepend Dalli patch if binary protocol defined
yiyuan-he
pushed a commit
to yiyuan-he/opentelemetry-ruby-contrib
that referenced
this pull request
May 14, 2025
…try#1489) chore: only prepend Dalli patch if binary protocol defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #1480.
We removed the binary protocol from Shopify's fork of Dalli (Shopify/dalli#13) since it is officially deprecated by Memcached (https://docs.memcached.org/protocols/#why-is-the-binary-protocol-deprecated). I know it's also on upstream Dalli's roadmap to remove it as well. So this PR just ensures that
::Dalli::Protocol::Binaryis defined before applying the patch.