From 936bc36f6b349824ce0041d918688eb2686a94d8 Mon Sep 17 00:00:00 2001 From: Michael He Date: Fri, 2 May 2025 03:10:04 +0000 Subject: [PATCH 1/2] fix: add missing semantic conventions require in AWS resource detectors --- resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb | 1 + resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb | 1 + resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb | 2 ++ 3 files changed, 4 insertions(+) diff --git a/resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb b/resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb index 0cee4fee51..581cc18924 100644 --- a/resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb +++ b/resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb @@ -7,6 +7,7 @@ require 'net/http' require 'json' require 'opentelemetry/common' +require 'opentelemetry/semantic_conventions/resource' module OpenTelemetry module Resource diff --git a/resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb b/resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb index b0386346b7..422769b151 100644 --- a/resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb +++ b/resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb @@ -8,6 +8,7 @@ require 'json' require 'socket' require 'opentelemetry/common' +require 'opentelemetry/semantic_conventions/resource' module OpenTelemetry module Resource diff --git a/resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb b/resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb index 8f3a83e0ef..f8db75bbfd 100644 --- a/resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb +++ b/resources/aws/lib/opentelemetry/resource/detector/aws/lambda.rb @@ -4,6 +4,8 @@ # # SPDX-License-Identifier: Apache-2.0 +require 'opentelemetry/semantic_conventions/resource' + module OpenTelemetry module Resource module Detector From e54f72fedf654d17a3fdfe72c7142b9ab90fcadb Mon Sep 17 00:00:00 2001 From: Michael He Date: Fri, 2 May 2025 20:47:53 +0000 Subject: [PATCH 2/2] fix: add semantic conventions require to top-level file --- resources/aws/lib/opentelemetry-resource-detector-aws.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/resources/aws/lib/opentelemetry-resource-detector-aws.rb b/resources/aws/lib/opentelemetry-resource-detector-aws.rb index a740ef21cc..806c814560 100644 --- a/resources/aws/lib/opentelemetry-resource-detector-aws.rb +++ b/resources/aws/lib/opentelemetry-resource-detector-aws.rb @@ -4,4 +4,5 @@ # # SPDX-License-Identifier: Apache-2.0 +require 'opentelemetry/semantic_conventions/resource' require_relative 'opentelemetry/resource/detector'