docs: Use AWS SDK v3 in example #1522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the AWS SDK documentation example to use the SDK v3 as discussed in #1470
It pretty much now implement the suggested example in the README itself:
opentelemetry-ruby-contrib/instrumentation/aws_sdk/README.md
Lines 47 to 58 in 51f6328
And I added the version restriction in the example Gemfile to avoid any confusion on the SDK version used.
I also added
rexml, because starting from Ruby 3.0 it isn't shipped with Ruby core, but aws-sdk-core needs an XML parser. It works on the AWS SDK CI without specifying rexml, because webmock requires rexml, but we don't have this gem in the example.If you run for example
AWS_ACCESS_KEY_ID=123 AWS_SECRET_ACCESS_KEY=qwer AWS_REGION=us-east-1 ruby trace_demonstration.rbyou will now get the example trace working :