fix: support GraphQL::Query::Partial in graphql instrumentation #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utay
requested review from
fbogsany,
mwear,
robertlaurin,
dazuma,
ericmustin,
arielvalentin,
ahayworth,
plantfansam,
robbkidd,
simi,
kaylareopelle,
xuan-cao-swi and
a team
as code owners
utay
force-pushed
the
graphql-query-partial
branch
from
1251a67 to
ce02bb9
Compare
Signed-off-by: Yannick Utard <[email protected]>
utay
force-pushed
the
graphql-query-partial
branch
from
ce02bb9 to
2e16b4a
Compare
|
Cc @rmosolgo |
rmosolgo
reviewed
Jul 16, 2025
instrumentation/graphql/lib/opentelemetry/instrumentation/graphql/tracers/graphql_trace.rb
Outdated
Show resolved
Hide resolved
Signed-off-by: Yannick Utard <[email protected]>
utay
force-pushed
the
graphql-query-partial
branch
from
43bf42f to
d78a028
Compare
|
Part of our expectations for accepting pull requests is adding automated tests that prevent future regressions. Please add some test coverage for these changes. |
|
👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
|
Hi @utay! Could you add some test coverage for this change like @arielvalentin mentioned above?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught this by using the
@streamdirective with graphql-ruby and got a NPE onquery.selected_operation.operation_type.Since graphql-ruby 2.5.6,
GraphQL::Query::Partialwas added for running sub-trees of valid queries. Thequeryargument ofexecute_querymight be aGraphQL::Query::Partialin which case we don't have direct access to the operation type and the query string; I thought in this case it would be nice to see the query path