fix: Fixing missing OpenTelemetry::Context detach on Excon instrumentation #1725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pafuent
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
…ation When a span is not recorded, for example when you are sampling traces, the OpenTelemetry::Context attached on `request_call` is never detached. This happens because `handle_response` is doing nothing if `span.recording?` is false. Here is example of the error that the missing detach generated: ``` ERROR -- : OpenTelemetry error: calls to detach should match corresponding calls to attach. ```
pafuent
force-pushed
the
instrumentation_excon_fixing_missing_context_detach_when_span_is_not_recorded
branch
from
05107f0 to
b4b77d0
Compare
…_detach_when_span_is_not_recorded
...mentation/excon/lib/opentelemetry/instrumentation/excon/middlewares/dup/tracer_middleware.rb
Outdated
Show resolved
Hide resolved
…_detach_when_span_is_not_recorded
pafuent
force-pushed
the
instrumentation_excon_fixing_missing_context_detach_when_span_is_not_recorded
branch
from
c583ed1 to
053afce
Compare
…_detach_when_span_is_not_recorded
arielvalentin
approved these changes
Oct 9, 2025
Contributor
arielvalentin
left a comment
arielvalentin
left a comment
There was a problem hiding this comment.
Thank you for this submission and fix!
kaylareopelle
approved these changes
Oct 9, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thank you! I really appreciate you adding the fix to all three conventions versions too! 🏆
…_detach_when_span_is_not_recorded
…_detach_when_span_is_not_recorded
pafuent
deleted the
instrumentation_excon_fixing_missing_context_detach_when_span_is_not_recorded
branch
americodls
pushed a commit
to intercom/opentelemetry-ruby-contrib
that referenced
this pull request
Oct 12, 2025
…ation (open-telemetry#1725) * fix: Fixing missing OpenTelemetry::Context detach on Excon instrumentation When a span is not recorded, for example when you are sampling traces, the OpenTelemetry::Context attached on `request_call` is never detached. This happens because `handle_response` is doing nothing if `span.recording?` is false. Here is example of the error that the missing detach generated: ``` ERROR -- : OpenTelemetry error: calls to detach should match corresponding calls to attach. ``` * Fixing tests following action_pack strategy to change the sampler * Improving datum handling --------- Co-authored-by: Kayla Reopelle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a span is not recorded, for example when you are sampling traces, the OpenTelemetry::Context attached on
request_callis never detached. This happens becausehandle_responseis doing nothing ifspan.recording?is false.Here is example of the error that the missing detach generated: