feat: use formatted_message in Ruby logger instrumentation #1746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoak
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
ericmustin
approved these changes
Oct 19, 2025
Contributor
ericmustin
left a comment
ericmustin
left a comment
There was a problem hiding this comment.
Is there a test we want here to prevent a regression ?
Contributor
Author
|
updated tests to assert that severity and msg are included in the body. The body changes from/to, for example, There is a newline on the end now. Is that going to cause any problems? (It seems fine in Loki.) The timestamp and process id are going to change every time. We could have a regex to assert more about the contents of the message though. |
kaylareopelle
approved these changes
Oct 20, 2025
Contributor
kaylareopelle
left a comment
kaylareopelle
left a comment
There was a problem hiding this comment.
Thanks, @wsmoak! As to your question about timestamps and process IDs, I think checking to see that the severity and body/message are both included in the body attribute should be sufficient for now for regression protection.
robbkidd
approved these changes
Oct 21, 2025
xuan-cao-swi
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
formatted_messagein the Ruby logger instrumentation so that the fully decorated log message is sent.Fixes #1745