Skip to content

Commit 000d4d3

Browse files
chore: Upgrade rubocop 0.73 -> 1.3 for SemanticConventions (#1391)
* Enable all new cops by default * TrailingBlankLines cop was renamed to TrailingEmptyLines * LineLength changed group from Metrics to Layout * disable Gemspec/RequireMFA * autocorrect slicing array from index until end Co-authored-by: Robert <[email protected]>
1 parent d3c9353 commit 000d4d3

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

semantic_conventions/.rubocop.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
AllCops:
22
TargetRubyVersion: '2.6.0'
3+
NewCops: enable
34

45
Bundler/OrderedGems:
56
Exclude:
@@ -8,7 +9,7 @@ Lint/UnusedMethodArgument:
89
Enabled: false
910
Metrics/AbcSize:
1011
Enabled: false
11-
Metrics/LineLength:
12+
Layout/LineLength:
1213
Enabled: false
1314
Metrics/MethodLength:
1415
Max: 20
@@ -33,5 +34,7 @@ Layout/EmptyLinesAroundModuleBody:
3334
Enabled: false
3435
Layout/TrailingWhitespace:
3536
Enabled: false
36-
Layout/TrailingBlankLines:
37-
Enabled: False
37+
Layout/TrailingEmptyLines:
38+
Enabled: false
39+
Gemspec/RequireMFA:
40+
Enabled: false

semantic_conventions/Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ task :generate do
5151
-f /source code
5252
--template /templates/semantic_conventions.j2
5353
--output /output/opentelemetry/semantic_conventions/#{kind}.rb
54-
-Dmodule=#{kind[0].upcase}#{kind[1..-1]}
54+
-Dmodule=#{kind[0].upcase}#{kind[1..]}
5555
]
5656

5757
puts "Running: #{cmd.join(' ')}"

semantic_conventions/opentelemetry-semantic_conventions.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Gem::Specification.new do |spec|
3030
spec.add_development_dependency 'bundler', '>= 1.17'
3131
spec.add_development_dependency 'minitest', '~> 5.0'
3232
spec.add_development_dependency 'rake', '~> 12.0'
33-
spec.add_development_dependency 'rubocop', '~> 0.73.0'
33+
spec.add_development_dependency 'rubocop', '~> 1.3'
3434
spec.add_development_dependency 'simplecov', '~> 0.17'
3535
spec.add_development_dependency 'yard', '~> 0.9'
3636
spec.add_development_dependency 'yard-doctest', '~> 0.1.6'

0 commit comments

Comments
 (0)