chore: add Rubocop additional linter (#1836)

* feat: additional rubocop linter

* lint

* add rubocop performance

---------

Co-authored-by: Kayla Reopelle <87386821+kaylareopelle@users.noreply.github.com>

Author: xuan-cao-swi

api/Gemfile

@@ -8,6 +8,8 @@ source 'https://rubygems.org'
 
 gemspec
 
+eval_gemfile '../contrib/Gemfile.shared'
+
 group :test, :development do
   gem 'opentelemetry-test-helpers', path: '../test_helpers'
 end

api/Rakefile

@@ -21,8 +21,11 @@ YARD::Rake::YardocTask.new do |t|
   t.stats_options = ['--list-undoc']
 end
 
-if RUBY_ENGINE == 'truffleruby'
-  task default: %i[test]
-else
-  task default: %i[test rubocop yard]
-end
+default_tasks =
+  if RUBY_ENGINE == 'truffleruby'
+    %i[test]
+  else
+    %i[test rubocop yard]
+  end
+
+task default: default_tasks

api/test/opentelemetry/trace/propagation/trace_context/trace_parent_test.rb

@@ -80,7 +80,7 @@
       value = '00-0000000000000000000000000000000a-000000000000000a-ff'
       assert TraceParent.from_string(value).sampled?
       value = '00-0000000000000000000000000000000a-000000000000000a-04'
-      assert !TraceParent.from_string(value).sampled?
+      refute TraceParent.from_string(value).sampled?
     end
 
     it 'must have a trace id of 16 hex bytes' do

api/test/opentelemetry/trace/tracestate_test.rb

@@ -75,7 +75,7 @@
       _(tracestate.to_h).must_equal('the-good-key' => '  the-good-value', '0x_the-vendor/key@my*v3nd0r' => 'another-great-value')
     end
     it 'will not exceed 32 members' do
-      tracestate = OpenTelemetry::Trace::Tracestate.from_hash(33.times.collect { |n| [n.to_s, n.to_s] }.to_h)
+      tracestate = OpenTelemetry::Trace::Tracestate.from_hash(Array.new(33) { |n| [n.to_s, n.to_s] }.to_h)
       _(tracestate.to_h.size).must_be :<=, 32
     end
   end
@@ -92,7 +92,7 @@
 
   describe '#set_value' do
     it 'will not exceed 32 members' do
-      tracestate = OpenTelemetry::Trace::Tracestate.from_hash(31.times.collect { |n| [n.to_s, n.to_s] }.to_h)
+      tracestate = OpenTelemetry::Trace::Tracestate.from_hash(Array.new(31) { |n| [n.to_s, n.to_s] }.to_h)
       tracestate = tracestate.set_value('a', 'a').set_value('b', 'b')
       _(tracestate.to_h.size).must_be :<=, 32
     end

common/Gemfile

@@ -8,6 +8,8 @@ source 'https://rubygems.org'
 
 gemspec
 
+eval_gemfile '../contrib/Gemfile.shared'
+
 group :development, :test do
   # Use the opentelemetry-api gem from source
   gem 'opentelemetry-api', path: '../api'

common/Rakefile

@@ -22,8 +22,11 @@ YARD::Rake::YardocTask.new do |t|
   t.stats_options = ['--list-undoc']
 end
 
-if RUBY_ENGINE == 'truffleruby'
-  task default: %i[test]
-else
-  task default: %i[test rubocop yard]
-end
+default_tasks =
+  if RUBY_ENGINE == 'truffleruby'
+    %i[test]
+  else
+    %i[test rubocop yard]
+  end
+
+task default: default_tasks

common/test/opentelemetry/common/utilities_test.rb

@@ -19,19 +19,19 @@ def shutdown(timeout: nil); end
 
   describe '#untraced?' do
     it 'returns true within an untraced block' do
-      assert_equal(true, common_utils.untraced { common_utils.untraced? })
+      assert(common_utils.untraced { common_utils.untraced? })
     end
 
     it 'returns false outside an untraced block' do
       common_utils.untraced {}
-      assert_equal(false, common_utils.untraced?)
+      refute(common_utils.untraced?)
     end
 
     it 'supports non block format' do
       token = OpenTelemetry::Context.attach(common_utils.untraced)
-      assert_equal(true, common_utils.untraced?)
+      assert(common_utils.untraced?)
       OpenTelemetry::Context.detach(token)
-      assert_equal(false, common_utils.untraced?)
+      refute(common_utils.untraced?)
     end
   end
 
@@ -48,7 +48,7 @@ def shutdown(timeout: nil); end
     end
 
     it 'with invalid conversion' do
-      time_bomb = "\xC2".dup.force_encoding(::Encoding::ASCII_8BIT)
+      time_bomb = (+"\xC2").force_encoding(::Encoding::ASCII_8BIT)
 
       # making sure this is indeed a problem
       assert_raises(Encoding::UndefinedConversionError) do
@@ -62,7 +62,7 @@ def shutdown(timeout: nil); end
     end
 
     it 'with binary data' do
-      byte_array = "keep what\xC2 is valid".dup.force_encoding(::Encoding::ASCII_8BIT)
+      byte_array = (+"keep what\xC2 is valid").force_encoding(::Encoding::ASCII_8BIT)
 
       assert_equal('keep what is valid', common_utils.utf8_encode(byte_array, binary: true))
     end

contrib/Gemfile.shared

@@ -0,0 +1,4 @@
+gem 'rubocop-rspec', '~> 3.5', require: false
+gem 'rubocop-rake', '~> 0.7.1', require: false
+gem 'rubocop-minitest', '~> 0.38.0', require: false
+gem 'rubocop-performance', '~> 1.25', require: false

contrib/rubocop.yml

@@ -1,3 +1,9 @@
+plugins:
+  - rubocop-minitest
+  - rubocop-rspec
+  - rubocop-rake
+  - rubocop-performance
+
 AllCops:
   NewCops: disable
   SuggestExtensions: false

exporter/jaeger/Gemfile

@@ -8,6 +8,8 @@ source 'https://rubygems.org'
 
 gemspec
 
+eval_gemfile '../../contrib/Gemfile.shared'
+
 group :test, :development do
   gem 'opentelemetry-api', path: '../../api'
   gem 'opentelemetry-common', path: '../../common'