fix: rack to stop using api env getter (#1037)

robertlaurin · web-flow · commit e53c8a7db9ce · 2021-11-29T15:01:32.000-06:00
diff --git a/instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb b/instrumentation/rack/lib/opentelemetry/instrumentation/rack/middlewares/tracer_middleware.rb
@@ -68,7 +68,7 @@ def call(env) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
             original_env = env.dup
             extracted_context = OpenTelemetry.propagation.extract(
               env,
-              getter: OpenTelemetry::Context::Propagation.rack_env_getter
+              getter: OpenTelemetry::Common::Propagation.rack_env_getter
             )
             frontend_context = create_frontend_span(env, extracted_context)
 
diff --git a/instrumentation/rack/opentelemetry-instrumentation-rack.gemspec b/instrumentation/rack/opentelemetry-instrumentation-rack.gemspec
@@ -26,6 +26,7 @@ Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 2.5.0'
 
   spec.add_dependency 'opentelemetry-api', '~> 1.0'
+  spec.add_dependency 'opentelemetry-common', '~> 0.19.2'
   spec.add_dependency 'opentelemetry-instrumentation-base', '~> 0.18.3'
 
   spec.add_development_dependency 'appraisal', '~> 2.2.0'

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ def call(env) # rubocop:disable Metrics/AbcSize, Metrics/MethodLength`
`68`	`68`	`original_env = env.dup`
`69`	`69`	`extracted_context = OpenTelemetry.propagation.extract(`
`70`	`70`	`env,`
`71`		`- getter: OpenTelemetry::Context::Propagation.rack_env_getter`
	`71`	`+ getter: OpenTelemetry::Common::Propagation.rack_env_getter`
`72`	`72`	`)`
`73`	`73`	`frontend_context = create_frontend_span(env, extracted_context)`
`74`	`74`