chore: Use PAT for release actions #1850
Conversation
A GitHub token will not trigger workflows associated with PRs. A PAT, however, should trigger those workflows automatically. This should stop us from needing to push empty commits when a release PR is opened.
| - name: Open release pull request | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} |
There was a problem hiding this comment.
I thought I tried this at some point and it did not work for me. Did you give this workflow a run from this branch?
There was a problem hiding this comment.
I thought this approach sounded familiar -- I haven't tried it on a workflow. added a dispatch and will check. that's not necessary since release-request has a dispatch... but I'm running into problems because the branch is on my fork.
There was a problem hiding this comment.
I'm open for suggestions on how to run the workflow from this branch. I'm not quite seeing how to smoothly do this without a release.
On another train of thought -- I looked to see the use of this secret in other OpenTelemetry repos.
Python has a nice comment about the use of the token in their release workflow.
And, when I look at their release PRs, I only see one commit:
open-telemetry/opentelemetry-python-contrib#3571
However, I can't see what jobs were run on that PR, so I can't be certain it's doing what we want it to do.
kaylareopelle
requested review from
ahayworth,
dazuma,
ericmustin,
fbogsany,
mwear,
plantfansam,
robbkidd and
robertlaurin
as code owners
2 participants
A GitHub token will not trigger workflows associated with PRs. A PAT, however, should trigger those workflows automatically. This should stop us from needing to push empty commits when a release PR is opened.
source