Skip to content

chore: Use PAT for release actions #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

chore: Use PAT for release actions #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
022ba4f
chore: Use PAT for release actions
kaylareopelle May 28, 2025
fd3300f
chore: add temporary workflow_dispatch test
kaylareopelle Jun 20, 2025
c9fd633
chore: remove workflow-dispatch from weekly runs
kaylareopelle Jun 20, 2025
9bd26ab
Merge branch 'main' into use-pat-for-releases
kaylareopelle Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-request-weekly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: "gem install --no-document toys -v 0.15.5"
- name: Open release pull request
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
Copy link
Contributor

@arielvalentin arielvalentin May 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I tried this at some point and it did not work for me. Did you give this workflow a run from this branch?

Copy link
Contributor Author

@kaylareopelle kaylareopelle Jun 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this approach sounded familiar -- I haven't tried it on a workflow. added a dispatch and will check. that's not necessary since release-request has a dispatch... but I'm running into problems because the branch is on my fork.

Copy link
Contributor Author

@kaylareopelle kaylareopelle Jun 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open for suggestions on how to run the workflow from this branch. I'm not quite seeing how to smoothly do this without a release.

On another train of thought -- I looked to see the use of this secret in other OpenTelemetry repos.

Python has a nice comment about the use of the token in their release workflow.

And, when I look at their release PRs, I only see one commit:
open-telemetry/opentelemetry-python-contrib#3571

However, I can't see what jobs were run on that PR, so I can't be certain it's doing what we want it to do.

run: |
toys release request --yes --verbose \
"--release-ref=${{ github.ref }}" \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
run: "gem install --no-document toys -v 0.15.5"
- name: Open release pull request
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }}
run: |
toys release request --yes --verbose \
"--gems=${{ github.event.inputs.gems }}" \
Expand Down