Use unstable sort to group traces in DD exporter. (#144)

mstyura · lalitb · web-flow · commit 0b253eb3324b · 2025-01-10T15:13:24.000+05:30
Co-authored-by: Lalit Kumar Bhasin &lt;lalit_fin@yahoo.com&gt;
diff --git a/opentelemetry-datadog/src/exporter/mod.rs b/opentelemetry-datadog/src/exporter/mod.rs
@@ -397,7 +397,7 @@ fn group_into_traces(spans: &mut [SpanData]) -> Vec<&[SpanData]> {
         return vec![];
     }
 
-    spans.sort_by_key(|x| x.span_context.trace_id().to_bytes());
+    spans.sort_unstable_by_key(|x| x.span_context.trace_id().to_bytes());
 
     let mut traces: Vec<&[SpanData]> = Vec::with_capacity(spans.len());
 

Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,7 @@ fn group_into_traces(spans: &mut [SpanData]) -> Vec<&[SpanData]> {`
`397`	`397`	`return vec![];`
`398`	`398`	`}`
`399`	`399`
`400`		`- spans.sort_by_key(\|x\| x.span_context.trace_id().to_bytes());`
	`400`	`+ spans.sort_unstable_by_key(\|x\| x.span_context.trace_id().to_bytes());`
`401`	`401`
`402`	`402`	`let mut traces: Vec<&[SpanData]> = Vec::with_capacity(spans.len());`
`403`	`403`