-
Notifications
You must be signed in to change notification settings - Fork 68
Open
Description
We must inspect the usage of unwrap()
in Geneva Uploader to ensure that there would be no panics at runtime.
Check the usage here for reference.
- We should try to avoid using
unwrap()
altogether either by checking the underlying value or provide some default withunwrap_or
etc. - For cases, where it's guaranteed that
unwrap()
would not result in panic, we should add a comment about safety and replaceunwrap()
withexpect()
.
lalitb