fix: Small improvement to OTLP Exporter logs

Author: cijothomas

opentelemetry-otlp/src/exporter/http/logs.rs

@@ -30,20 +30,24 @@ impl LogExporter for OtlpHttpClient {
         }
 
         let request_uri = request.uri().to_string();
-        otel_debug!(name: "HttpLogsClient.CallingExport");
+        otel_debug!(name: "HttpLogsClient.ExportStarted");
         let response = client
             .send_bytes(request)
             .await
             .map_err(|e| OTelSdkError::InternalFailure(format!("{e:?}")))?;
+
         if !response.status().is_success() {
             let error = format!(
                 "OpenTelemetry logs export failed. Url: {}, Status Code: {}, Response: {:?}",
                 request_uri,
                 response.status().as_u16(),
                 response.body()
             );
+            otel_debug!(name: "HttpLogsClient.ExportFailed", error = &error);
             return Err(OTelSdkError::InternalFailure(error));
         }
+
+        otel_debug!(name: "HttpLogsClient.ExportSucceeded");
         Ok(())
     }
 

opentelemetry-otlp/src/exporter/http/metrics.rs

@@ -33,13 +33,31 @@ impl MetricsClient for OtlpHttpClient {
             request.headers_mut().insert(k.clone(), v.clone());
         }
 
-        otel_debug!(name: "HttpMetricsClient.CallingExport");
-        client
+        otel_debug!(name: "HttpMetricsClient.ExportStarted");
+        let result = client
             .send_bytes(request)
-            .await
-            .map_err(|e| OTelSdkError::InternalFailure(format!("{e:?}")))?;
+            .await;
 
-        Ok(())
+        match result {
+            Ok(response) => {
+                if response.status().is_success() {
+                    otel_debug!(name: "HttpMetricsClient.ExportSucceeded");
+                    Ok(())
+                } else {
+                    let error = format!(
+                        "OpenTelemetry metrics export failed. Status Code: {}, Response: {:?}",
+                        response.status().as_u16(),
+                        response.body()
+                    );
+                    otel_debug!(name: "HttpMetricsClient.ExportFailed", error = &error);
+                    Err(OTelSdkError::InternalFailure(error))
+                }
+            }
+            Err(e) => {
+                otel_debug!(name: "HttpMetricsClient.ExportFailed", error = format!("{:?}", e));
+                Err(OTelSdkError::InternalFailure(format!("{e:?}")))
+            }
+        }
     }
 
     fn shutdown(&self) -> OTelSdkResult {

opentelemetry-otlp/src/exporter/http/trace.rs

@@ -42,7 +42,7 @@ impl SpanExporter for OtlpHttpClient {
         }
 
         let request_uri = request.uri().to_string();
-        otel_debug!(name: "HttpTracesClient.CallingExport");
+        otel_debug!(name: "HttpTracesClient.ExportStarted");
         let response = client
             .send_bytes(request)
             .await
@@ -51,13 +51,15 @@ impl SpanExporter for OtlpHttpClient {
         if !response.status().is_success() {
             let error = format!(
                 "OpenTelemetry trace export failed. Url: {}, Status Code: {}, Response: {:?}",
-                response.status().as_u16(),
                 request_uri,
+                response.status().as_u16(),
                 response.body()
             );
+            otel_debug!(name: "HttpTracesClient.ExportFailed", error = &error);
             return Err(OTelSdkError::InternalFailure(error));
         }
 
+        otel_debug!(name: "HttpTracesClient.ExportSucceeded");
         Ok(())
     }
 

opentelemetry-otlp/src/exporter/tonic/logs.rs

@@ -72,17 +72,26 @@ impl LogExporter for TonicLogsClient {
 
         let resource_logs = group_logs_by_resource_and_scope(batch, &self.resource);
 
-        otel_debug!(name: "TonicsLogsClient.CallingExport");
+        otel_debug!(name: "TonicLogsClient.ExportStarted");
 
-        client
+        let result = client
             .export(Request::from_parts(
                 metadata,
                 extensions,
                 ExportLogsServiceRequest { resource_logs },
             ))
-            .await
-            .map_err(|e| OTelSdkError::InternalFailure(format!("export error: {:?}", e)))?;
-        Ok(())
+            .await;
+
+        match result {
+            Ok(_) => {
+                otel_debug!(name: "TonicLogsClient.ExportSucceeded");
+                Ok(())
+            }
+            Err(e) => {
+                otel_debug!(name: "TonicLogsClient.ExportFailed", error = format!("{:?}", e));
+                Err(OTelSdkError::InternalFailure(format!("export error: {:?}", e)))
+            }
+        }
     }
 
     fn shutdown_with_timeout(&self, _timeout: time::Duration) -> OTelSdkResult {

opentelemetry-otlp/src/exporter/tonic/metrics.rs

@@ -75,18 +75,26 @@ impl MetricsClient for TonicMetricsClient {
                 )),
             })?;
 
-        otel_debug!(name: "TonicsMetricsClient.CallingExport");
+        otel_debug!(name: "TonicMetricsClient.ExportStarted");
 
-        client
+        let result = client
             .export(Request::from_parts(
                 metadata,
                 extensions,
                 ExportMetricsServiceRequest::from(metrics),
             ))
-            .await
-            .map_err(|e| OTelSdkError::InternalFailure(format!("{e:?}")))?;
+            .await;
 
-        Ok(())
+        match result {
+            Ok(_) => {
+                otel_debug!(name: "TonicMetricsClient.ExportSucceeded");
+                Ok(())
+            }
+            Err(e) => {
+                otel_debug!(name: "TonicMetricsClient.ExportFailed", error = format!("{:?}", e));
+                Err(OTelSdkError::InternalFailure(format!("{e:?}")))
+            }
+        }
     }
 
     fn shutdown(&self) -> OTelSdkResult {

opentelemetry-otlp/src/exporter/tonic/trace.rs

@@ -76,17 +76,27 @@ impl SpanExporter for TonicTracesClient {
 
         let resource_spans = group_spans_by_resource_and_scope(batch, &self.resource);
 
-        otel_debug!(name: "TonicsTracesClient.CallingExport");
 
-        client
+        otel_debug!(name: "TonicTracesClient.ExportStarted");
+
+        let result = client
             .export(Request::from_parts(
                 metadata,
                 extensions,
                 ExportTraceServiceRequest { resource_spans },
             ))
-            .await
-            .map_err(|e| OTelSdkError::InternalFailure(e.to_string()))?;
-        Ok(())
+            .await;
+
+        match result {
+            Ok(_) => {
+                otel_debug!(name: "TonicTracesClient.ExportSucceeded");
+                Ok(())
+            }
+            Err(e) => {
+                otel_debug!(name: "TonicTracesClient.ExportFailed", error = format!("{:?}", e));
+                Err(OTelSdkError::InternalFailure(e.to_string()))
+            }
+        }
     }
 
     fn shutdown(&mut self) -> OTelSdkResult {